From 039be71b87a0a43f772015e84d6c8d65d63e5016 Mon Sep 17 00:00:00 2001 From: Chad Little Date: Thu, 16 Jul 2015 21:02:01 -0700 Subject: [PATCH] Fix a phutil_json_decode call in CustomField PHID Summary: I assume this is correct, it fixes my test case and was inconsistent with the rest of the file. Test Plan: Add and Remove a CustomFieldPHID in Maniphest, no longer get errors. Reviewers: btrahan, epriestley Reviewed By: epriestley Subscribers: epriestley, Korvin Maniphest Tasks: T8866 Differential Revision: https://secure.phabricator.com/D13642 --- .../standard/PhabricatorStandardCustomFieldPHIDs.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldPHIDs.php b/src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldPHIDs.php index dc7ed2d1e4..842d662904 100644 --- a/src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldPHIDs.php +++ b/src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldPHIDs.php @@ -118,7 +118,7 @@ abstract class PhabricatorStandardCustomFieldPHIDs $old = array(); } - $new = phutil_json_decode($xaction->getNewValue()); + $new = json_decode($xaction->getNewValue()); if (!is_array($new)) { $new = array(); }