From 03a108e121cac2cfe8530ff97bc9dec85b759d4f Mon Sep 17 00:00:00 2001 From: vrana Date: Thu, 1 Mar 2012 17:57:19 -0800 Subject: [PATCH] Don't throw exception in diff versus file removed from revision Test Plan: Display a revision where a file was removed compared to previous diffs, like https://secure.phabricator.com/D1724?vs=3008&id=3009. Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1754 --- .../changesetview/DifferentialChangesetViewController.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/applications/differential/controller/changesetview/DifferentialChangesetViewController.php b/src/applications/differential/controller/changesetview/DifferentialChangesetViewController.php index d761ffe025..1e54d9a376 100644 --- a/src/applications/differential/controller/changesetview/DifferentialChangesetViewController.php +++ b/src/applications/differential/controller/changesetview/DifferentialChangesetViewController.php @@ -130,7 +130,7 @@ class DifferentialChangesetViewController extends DifferentialController { } $coverage = null; - if ($right->getDiffID()) { + if ($right && $right->getDiffID()) { $unit = id(new DifferentialDiffProperty())->loadOneWhere( 'diffID = %d AND name = %s', $right->getDiffID(),