Reduce STATUS_CLOSED (now internally "Published") revision status callsites

Summary:
Ref T2543. Add `isPublished()` to mean: exactly the status 'closed', which is now interally called 'published', but still shown as 'closed' to users.

We have some callsites which are about "exactly that status", vs "any 'closed' status", e.g. including "abandoned".

This also introduces `isChangePlanned()`, which felt less awkward than `isChangesPlanned()` but more consistent than `hasChangesPlanned()` or `isStatusChangesPlanned()` or similar.

Test Plan: `grep`, loaded revisions, requested review.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T2543

Differential Revision: https://secure.phabricator.com/D18341

src/applications/differential/conduit/DifferentialUpdateRevisionConduitAPIMethod.php

@@ -69,7 +69,7 @@ final class DifferentialUpdateRevisionConduitAPIMethod
       throw new ConduitException('ERR_BAD_REVISION');
     }
 
-    if ($revision->getStatus() == ArcanistDifferentialRevisionStatus::CLOSED) {
+    if ($revision->isPublished()) {
       throw new ConduitException('ERR_CLOSED');
     }
 

src/applications/differential/constants/DifferentialRevisionStatus.php

@@ -44,6 +44,14 @@ final class DifferentialRevisionStatus extends Phobject {
     return ($this->key === self::NEEDS_REVIEW);
   }
 
+  public function isPublished() {
+    return ($this->key === self::PUBLISHED);
+  }
+
+  public function isChangePlanned() {
+    return ($this->key === self::CHANGES_PLANNED);
+  }
+
   public static function newForLegacyStatus($legacy_status) {
     $result = new self();
 

src/applications/differential/storage/DifferentialRevision.php

@@ -628,6 +628,14 @@ final class DifferentialRevision extends DifferentialDAO
     return $this->getStatusObject()->isNeedsReview();
   }
 
+  public function isChangePlanned() {
+    return $this->getStatusObject()->isChangePlanned();
+  }
+
+  public function isPublished() {
+    return $this->getStatusObject()->isPublished();
+  }
+
   public function getStatusIcon() {
     return $this->getStatusObject()->getIcon();
   }

src/applications/differential/xaction/DifferentialRevisionPlanChangesTransaction.php

@@ -56,9 +56,7 @@ final class DifferentialRevisionPlanChangesTransaction
   }
 
   protected function validateAction($object, PhabricatorUser $viewer) {
-    $status_planned = ArcanistDifferentialRevisionStatus::CHANGES_PLANNED;
+    if ($object->isChangePlanned()) {
-
-    if ($object->getStatus() == $status_planned) {
       throw new Exception(
         pht(
           'You can not request review of this revision because this '.

src/applications/differential/xaction/DifferentialRevisionReopenTransaction.php

@@ -39,10 +39,7 @@ final class DifferentialRevisionReopenTransaction
   }
 
   protected function validateAction($object, PhabricatorUser $viewer) {
-    // Note that we're testing for "Closed", exactly, not just any closed
+    if ($object->isPublished()) {
-    // status.
-    $status_closed = ArcanistDifferentialRevisionStatus::CLOSED;
-    if ($object->getStatus() != $status_closed) {
       throw new Exception(
         pht(
           'You can not reopen this revision because it is not closed. '.

src/applications/differential/xaction/DifferentialRevisionRequestReviewTransaction.php

@@ -37,8 +37,7 @@ final class DifferentialRevisionRequestReviewTransaction
   }
 
   protected function validateAction($object, PhabricatorUser $viewer) {
-    $status_review = ArcanistDifferentialRevisionStatus::NEEDS_REVIEW;
+    if ($object->isNeedsReview()) {
-    if ($object->getStatus() == $status_review) {
       throw new Exception(
         pht(
           'You can not request review of this revision because this '.

src/applications/repository/worker/commitmessageparser/PhabricatorRepositoryCommitMessageParserWorker.php

@@ -203,10 +203,7 @@ abstract class PhabricatorRepositoryCommitMessageParserWorker
           $revision->getID(),
           $commit->getPHID());
 
-        $status_closed = ArcanistDifferentialRevisionStatus::CLOSED;
+        $should_close = !$revision->isPublished() && $should_autoclose;
-        $should_close = ($revision->getStatus() != $status_closed) &&
-                        $should_autoclose;
-
         if ($should_close) {
            $commit_close_xaction = id(new DifferentialTransaction())
             ->setTransactionType(DifferentialTransaction::TYPE_ACTION)