From 04c1f67a020ccd8cd1755e6a4df5d5d9aa670182 Mon Sep 17 00:00:00 2001 From: epriestley Date: Mon, 11 Jan 2021 10:47:48 -0800 Subject: [PATCH] Add "M" and "P" to the default Remarkup ignore list Summary: Ref T13575. Particularly with the new Apple silicon, I think there are enough domain collisions for `M1`, `M2`, `P1`, etc., to justify adding them to the default ignore list. Test Plan: Created a mock, then wrote a comment referencing an object on the list (`M1`) and an object not on the list (`T1`). Got text and a link respectively. Maniphest Tasks: T13575 Differential Revision: https://secure.phabricator.com/D21507 --- .../option/PhabricatorCoreConfigOptions.php | 16 +++++++++++++++- 1 file changed, 15 insertions(+), 1 deletion(-) diff --git a/src/applications/config/option/PhabricatorCoreConfigOptions.php b/src/applications/config/option/PhabricatorCoreConfigOptions.php index 10f3e75b62..77c48115a4 100644 --- a/src/applications/config/option/PhabricatorCoreConfigOptions.php +++ b/src/applications/config/option/PhabricatorCoreConfigOptions.php @@ -169,7 +169,21 @@ EOREMARKUP 'Maniphest. If you\'d prefer more traditional UI strings like '. '"Add Comment", you can set this flag to disable most of the '. 'extra flavor.')), - $this->newOption('remarkup.ignored-object-names', 'string', '/^(Q|V)\d$/') + $this->newOption( + 'remarkup.ignored-object-names', + 'string', + + // Q1, Q2, etc., are common abbreviations for "Quarter". + // V1, V2, etc., are common abbreviations for "Version". + // P1, P2, etc., are common abbreviations for "Priority". + + // M1 is a computer chip manufactured by Apple. + // M2 (commonly spelled "M.2") is an expansion slot on motherboards. + // M4 is a carbine. + // M8 is a phonetic spelling of "mate", used in culturally significant + // copypasta about navy seals. + + '/^(Q|V|M|P)\d$/') ->setSummary( pht('Text values that match this regex and are also object names '. 'will not be linked.'))