revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-27 01:02:42 +01:00
Code Issues Releases Wiki Activity

Make columns in flag view not squish each other

Browse source 
Summary:
Unlike (all? most?) other tables, the flag table has two wide
columns: the object name and the flag note. This fiddles with the
classes so neither gets squished too much by the other.

This is kind of a hack and I don't even know if it's cross-browser
compatible because I only have WebKit here. But maybe it's fine.

Test Plan:
View Differential home page while changing revision names and
flag notes to weird things.

Reviewers: epriestley

Reviewed By: epriestley

CC: aran, Korvin

Maniphest Tasks: T1586

Differential Revision: https://secure.phabricator.com/D3128
This commit is contained in:
Alan Huang 2012-08-02 13:58:54 -07:00
parent d31accf076
commit 04fafdb75c
2 changed files with 11 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
src/applications/flag/view/PhabricatorFlagListView.php
View file

@ -92,12 +92,12 @@ final class PhabricatorFlagListView extends AphrontView {
)); ));
$table->setColumnClasses( $table->setColumnClasses(
array( array(
'', 'narrow',
'pri', 'wrap pri',
'wide', 'wrap',
'', 'narrow',
'action', 'narrow action',
'action', 'narrow action',
)); ));
$table->setNoDataString('No flags.'); $table->setNoDataString('No flags.');

6
webroot/rsrc/css/aphront/table-view.css
View file

@ -91,10 +91,14 @@
text-align: right; text-align: right;
} }
.aprhont-table-view td.wrap { .aphront-table-view td.wrap {
white-space: normal; white-space: normal;
} }
.aphront-table-view td.narrow {
width: 1px;
}
div.single-display-line-bounds { div.single-display-line-bounds {
width: 100%; width: 100%;
position: relative; position: relative;