From 051276a96b08271def81e76b4614078f5bc54386 Mon Sep 17 00:00:00 2001
From: epriestley <git@epriestley.com>
Date: Wed, 12 Dec 2012 18:40:18 -0800
Subject: [PATCH] Minor cleanups to Diffusion breadcrumbs

Summary:
  - Remove "Diffusion" crumb (redundant with application icon)
  - Put "All Repositories" in its place on the landing page.
  - Render the repository crumb as "rX" instead of "X Repository".

Test Plan: Looked at various Diffusion pages.

Reviewers: btrahan

Reviewed By: btrahan

CC: aran

Differential Revision: https://secure.phabricator.com/D4173
---
 .../diffusion/controller/DiffusionController.php          | 8 ++------
 .../diffusion/controller/DiffusionHomeController.php      | 4 ++++
 2 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/src/applications/diffusion/controller/DiffusionController.php b/src/applications/diffusion/controller/DiffusionController.php
index 08fffae287..7343426a15 100644
--- a/src/applications/diffusion/controller/DiffusionController.php
+++ b/src/applications/diffusion/controller/DiffusionController.php
@@ -157,21 +157,17 @@ abstract class DiffusionController extends PhabricatorController {
       $repository = null;
     }
 
-    $crumb = id(new PhabricatorCrumbView())
-      ->setName('Diffusion')
-      ->setHref('/diffusion/');
-    $crumb_list[] = $crumb;
     if (!$repository) {
       return $crumb_list;
     }
 
     $callsign = $repository->getCallsign();
-    $repository_name = phutil_escape_html($repository->getName()).' Repository';
+    $repository_name = 'r'.$callsign;
 
     if (!$spec['commit'] && !$spec['tags'] && !$spec['branches']) {
       $branch_name = $drequest->getBranch();
       if ($branch_name) {
-        $repository_name .= ' ('.phutil_escape_html($branch_name).')';
+        $repository_name .= ' ('.$branch_name.')';
       }
     }
 
diff --git a/src/applications/diffusion/controller/DiffusionHomeController.php b/src/applications/diffusion/controller/DiffusionHomeController.php
index e3b1b6d520..8c462afb5f 100644
--- a/src/applications/diffusion/controller/DiffusionHomeController.php
+++ b/src/applications/diffusion/controller/DiffusionHomeController.php
@@ -200,6 +200,10 @@ final class DiffusionHomeController extends DiffusionController {
     $panel->appendChild($table);
 
     $crumbs = $this->buildCrumbs();
+    $crumbs->addCrumb(
+      id(new PhabricatorCrumbView())
+        ->setName(pht('All Repositories'))
+        ->setHref($this->getApplicationURI()));
 
     return $this->buildStandardPageResponse(
       array(