From 05607aedf9799ee405b4a178389df69ea5c12e5a Mon Sep 17 00:00:00 2001
From: Chad Little <chad@chadsdomain.com>
Date: Fri, 28 Feb 2014 11:16:11 -0800
Subject: [PATCH] Normalize spacing around empty object lists

Summary: Adds an li for semantics, fixes spacing around error view in a phui-box or not

Test Plan: view a project with no tasks, perform a search with no data returned.

Reviewers: epriestley

Reviewed By: epriestley

CC: Korvin, epriestley, aran

Differential Revision: https://secure.phabricator.com/D8371
---
 resources/celerity/map.php                           | 6 +++---
 src/view/phui/PHUIObjectItemListView.php             | 8 +++++++-
 webroot/rsrc/css/phui/phui-object-item-list-view.css | 8 ++------
 3 files changed, 12 insertions(+), 10 deletions(-)

diff --git a/resources/celerity/map.php b/resources/celerity/map.php
index aba99b523f..ceb71e2c69 100644
--- a/resources/celerity/map.php
+++ b/resources/celerity/map.php
@@ -7,7 +7,7 @@
 return array(
   'names' =>
   array(
-    'core.pkg.css' => 'f12d87a6',
+    'core.pkg.css' => '7c181600',
     'core.pkg.js' => 'b7bdab05',
     'darkconsole.pkg.js' => 'ca8671ce',
     'differential.pkg.css' => 'd1b3a605',
@@ -138,7 +138,7 @@ return array(
     'rsrc/css/phui/phui-info-panel.css' => '27ea50a1',
     'rsrc/css/phui/phui-list.css' => '2edb76cf',
     'rsrc/css/phui/phui-object-box.css' => 'ce92d8ec',
-    'rsrc/css/phui/phui-object-item-list-view.css' => 'eb579d6c',
+    'rsrc/css/phui/phui-object-item-list-view.css' => '4e4e3d4c',
     'rsrc/css/phui/phui-pinboard-view.css' => '4b346c2a',
     'rsrc/css/phui/phui-property-list-view.css' => 'dbf53b12',
     'rsrc/css/phui/phui-remarkup-preview.css' => '19ad512b',
@@ -753,7 +753,7 @@ return array(
     'phui-info-panel-css' => '27ea50a1',
     'phui-list-view-css' => '2edb76cf',
     'phui-object-box-css' => 'ce92d8ec',
-    'phui-object-item-list-view-css' => 'eb579d6c',
+    'phui-object-item-list-view-css' => '4e4e3d4c',
     'phui-pinboard-view-css' => '4b346c2a',
     'phui-property-list-view-css' => 'dbf53b12',
     'phui-remarkup-preview-css' => '19ad512b',
diff --git a/src/view/phui/PHUIObjectItemListView.php b/src/view/phui/PHUIObjectItemListView.php
index b57d01a04b..f1efc05fc2 100644
--- a/src/view/phui/PHUIObjectItemListView.php
+++ b/src/view/phui/PHUIObjectItemListView.php
@@ -107,9 +107,15 @@ final class PHUIObjectItemListView extends AphrontTagView {
       $items = null;
     } else {
       $string = nonempty($this->noDataString, pht('No data.'));
-      $items = id(new AphrontErrorView())
+      $string = id(new AphrontErrorView())
         ->setSeverity(AphrontErrorView::SEVERITY_NODATA)
         ->appendChild($string);
+      $items = phutil_tag(
+        'li',
+        array(
+          'class' => 'phui-object-item-empty'),
+        $string);
+
     }
 
     $pager = null;
diff --git a/webroot/rsrc/css/phui/phui-object-item-list-view.css b/webroot/rsrc/css/phui/phui-object-item-list-view.css
index 16d4b315f1..6d63bacf63 100644
--- a/webroot/rsrc/css/phui/phui-object-item-list-view.css
+++ b/webroot/rsrc/css/phui/phui-object-item-list-view.css
@@ -29,7 +29,8 @@
 }
 
 .phui-object-item-list-view .aphront-error-view {
-  margin: 0;
+  margin: 4px 0 8px 0;
+  color: {$bluetext};
 }
 
 .phui-object-item {
@@ -415,11 +416,6 @@
   background: {$lightblue};
 }
 
-.phui-object-list-flush .aphront-error-view {
-  margin: 0;
-  background: #fff;
-}
-
 
 /* - Foot Icons ----------------------------------------------------------------