mirror of
https://we.phorge.it/source/phorge.git
synced 2024-11-10 00:42:41 +01:00
Fix PHP 8.1 "strlen(null)" exception for "/bin/files generate-key" without parameter
Summary: `strlen()` was used in Phabricator to check if a generic value is a non-empty string. This behavior is deprecated since PHP 8.1. Phorge adopts `phutil_nonempty_string()` as a replacement. Note: this may highlight other absurd input values that might be worth correcting instead of just ignoring. If phutil_nonempty_string() throws an exception in your instance, report it to Phorge to evaluate and fix that specific corner case. ``` ERROR 8192: strlen(): Passing null to parameter #1 ($string) of type string is deprecated at [/var/www/html/phorge/phorge/src/applications/files/management/PhabricatorFilesManagementGenerateKeyWorkflow.php:23] ``` Test Plan: Run `../phorge/bin/files generate-key`: Get no `strlen()` error anymore but only expected output `Usage Exception: Specify the type of key to generate with --type.` Reviewers: O1 Blessed Committers, valerio.bozzolan Reviewed By: O1 Blessed Committers, valerio.bozzolan Subscribers: tobiaswiese, valerio.bozzolan, Matthew, Cigaryno Differential Revision: https://we.phorge.it/D25579
This commit is contained in:
parent
79464882da
commit
05798a6301
1 changed files with 1 additions and 1 deletions
|
@ -20,7 +20,7 @@ final class PhabricatorFilesManagementGenerateKeyWorkflow
|
|||
|
||||
public function execute(PhutilArgumentParser $args) {
|
||||
$type = $args->getArg('type');
|
||||
if (!strlen($type)) {
|
||||
if (!phutil_nonempty_string($type)) {
|
||||
throw new PhutilArgumentUsageException(
|
||||
pht(
|
||||
'Specify the type of key to generate with --type.'));
|
||||
|
|
Loading…
Reference in a new issue