revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2025-02-21 03:08:40 +01:00
Code Issues Releases Wiki Activity

Yell at developers if they don't replace the default revision title with thier new revision title.

Browse source 
Summary: Same as the title

Test Plan: Will test locally by running arc diff

Reviewers: epriestley

Reviewed By: epriestley

CC: aran, Korvin, AnhNhan, starruler

Maniphest Tasks: T2663

Differential Revision: https://secure.phabricator.com/D5297
This commit is contained in:
Afaque Hussain 2013-03-13 09:34:23 -07:00 • committed by epriestley
parent 7487c57401
commit 05c5c43159
2 changed files with 16 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
src/applications/differential/conduit/ConduitAPI_differential_getcommitmessage_Method.php
View file

@ -102,7 +102,8 @@ final class ConduitAPI_differential_getcommitmessage_Method
$label = $field->renderLabelForCommitMessage();
if (!strlen($value)) {
if ($field_key === 'title') {
$commit_message[] = '<<Enter Revision Title>>';
$commit_message[] =
DifferentialTitleFieldSpecification::getDefaultRevisionTitle();
} else {
if ($field->shouldAppearOnCommitMessageTemplate() && $is_edit) {
$commit_message[] = $label.': ';

15
src/applications/differential/field/specification/DifferentialTitleFieldSpecification.php
View file

@ -41,7 +41,16 @@ final class DifferentialTitleFieldSpecification
if (!strlen($this->title)) {
$this->error = 'Required';
throw new DifferentialFieldValidationException(
"You must provide a title.");
"You must provide a revision title in the first line ".
"of your commit message.");
}
if (preg_match('/^<<.*>>$/', $this->title)) {
$default_title = self::getDefaultRevisionTitle();
$this->error = 'Required';
throw new DifferentialFieldValidationException(
"Replace the line '{$default_title}' with a revision title ".
"that describes the change.");
}
}
@ -86,6 +95,10 @@ final class DifferentialTitleFieldSpecification
return 'wide pri';
}
public static function getDefaultRevisionTitle() {
return '<<Replace this line with your Revision Title>>';
}
public function renderValueForRevisionList(DifferentialRevision $revision) {
return phutil_tag(
'a',