From 05eb77c0a704c933b69006ceaca5ebf1e626ae6a Mon Sep 17 00:00:00 2001
From: epriestley <git@epriestley.com>
Date: Thu, 21 Aug 2014 14:45:51 -0700
Subject: [PATCH] Mark redirects to php.net from symbols as external

Summary: Fixes T5942. These are external but currently unmarked.

Test Plan: Visited link, got redirected.

Reviewers: btrahan, chad

Reviewed By: chad

Subscribers: epriestley

Maniphest Tasks: T5942

Differential Revision: https://secure.phabricator.com/D10332
---
 .../diffusion/controller/DiffusionSymbolController.php          | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/src/applications/diffusion/controller/DiffusionSymbolController.php b/src/applications/diffusion/controller/DiffusionSymbolController.php
index 16635c708b..7267ab849e 100644
--- a/src/applications/diffusion/controller/DiffusionSymbolController.php
+++ b/src/applications/diffusion/controller/DiffusionSymbolController.php
@@ -57,6 +57,7 @@ final class DiffusionSymbolController extends DiffusionController {
           $functions = get_defined_functions();
           if (in_array($this->name, $functions['internal'])) {
             return id(new AphrontRedirectResponse())
+              ->setIsExternal(true)
               ->setURI('http://www.php.net/function.'.$this->name);
           }
         }
@@ -65,6 +66,7 @@ final class DiffusionSymbolController extends DiffusionController {
               interface_exists($this->name, false)) {
             if (id(new ReflectionClass($this->name))->isInternal()) {
               return id(new AphrontRedirectResponse())
+                ->setIsExternal(true)
                 ->setURI('http://www.php.net/class.'.$this->name);
             }
           }