Add getQueryApplicationClass() to *TransactionQuery.php classes

Summary:
Add `getQueryApplicationClass()` to all `*TransactionQuery.php` classes similar to other `*Query.php` classes having the same function, and make the parent function in `PhabricatorApplicationTransactionQuery.php` abstract.

In the future, this will enable excluding transaction query results based on their underlying application (for example if an application has been uninstalled) to mitigate the problem of overheated search results. See https://we.phorge.it/T15642 for context.

The only callers of `getQueryApplicationClass()` are in `src/infrastructure/query/policy/PhabricatorPolicyAwareQuery.php` and `src/applications/policy/__tests__/PhabricatorPolicyTestCase.php`.

See T15642

Test Plan:
Patch changes only one existing code place, thus check if related pages still work as expected:
* Go to http://phorge.localhost/feed/
* Go to http://phorge.localhost/feed/transactions/
* On http://phorge.localhost/feed/transactions/ , click `Edit Query` and set `Object Types` to `Application` etc.

Reviewers: O1 Blessed Committers, valerio.bozzolan

Reviewed By: O1 Blessed Committers, valerio.bozzolan

Subscribers: tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Maniphest Tasks: T15642

Differential Revision: https://we.phorge.it/D25500

src/applications/almanac/query/AlmanacBindingTransactionQuery.php

@@ -7,4 +7,8 @@ final class AlmanacBindingTransactionQuery
     return new AlmanacBindingTransaction();
   }
 
+  public function getQueryApplicationClass() {
+    return PhabricatorAlmanacApplication::class;
+  }
+
 }

src/applications/almanac/query/AlmanacDeviceTransactionQuery.php

@@ -7,4 +7,8 @@ final class AlmanacDeviceTransactionQuery
     return new AlmanacDeviceTransaction();
   }
 
+  public function getQueryApplicationClass() {
+    return PhabricatorAlmanacApplication::class;
+  }
+
 }

src/applications/almanac/query/AlmanacInterfaceTransactionQuery.php

@@ -7,4 +7,8 @@ final class AlmanacInterfaceTransactionQuery
     return new AlmanacInterfaceTransaction();
   }
 
+  public function getQueryApplicationClass() {
+    return PhabricatorAlmanacApplication::class;
+  }
+
 }

src/applications/almanac/query/AlmanacNamespaceTransactionQuery.php

@@ -7,4 +7,8 @@ final class AlmanacNamespaceTransactionQuery
     return new AlmanacNamespaceTransaction();
   }
 
+  public function getQueryApplicationClass() {
+    return PhabricatorAlmanacApplication::class;
+  }
+
 }

src/applications/almanac/query/AlmanacNetworkTransactionQuery.php

@@ -7,4 +7,8 @@ final class AlmanacNetworkTransactionQuery
     return new AlmanacNetworkTransaction();
   }
 
+  public function getQueryApplicationClass() {
+    return PhabricatorAlmanacApplication::class;
+  }
+
 }

src/applications/almanac/query/AlmanacServiceTransactionQuery.php

@@ -7,4 +7,8 @@ final class AlmanacServiceTransactionQuery
     return new AlmanacServiceTransaction();
   }
 
+  public function getQueryApplicationClass() {
+    return PhabricatorAlmanacApplication::class;
+  }
+
 }

src/applications/audit/query/PhabricatorAuditTransactionQuery.php

@@ -7,4 +7,8 @@ final class PhabricatorAuditTransactionQuery
     return new PhabricatorAuditTransaction();
   }
 
+  public function getQueryApplicationClass() {
+    return PhabricatorAuditApplication::class;
+  }
+
 }

src/applications/auth/query/PhabricatorAuthContactNumberTransactionQuery.php

@@ -7,4 +7,8 @@ final class PhabricatorAuthContactNumberTransactionQuery
     return new PhabricatorAuthContactNumberTransaction();
   }
 
+  public function getQueryApplicationClass() {
+    return PhabricatorAuthApplication::class;
+  }
+
 }

src/applications/auth/query/PhabricatorAuthFactorProviderTransactionQuery.php

@@ -7,4 +7,8 @@ final class PhabricatorAuthFactorProviderTransactionQuery
     return new PhabricatorAuthFactorProviderTransaction();
   }
 
+  public function getQueryApplicationClass() {
+    return PhabricatorAuthApplication::class;
+  }
+
 }

src/applications/auth/query/PhabricatorAuthMessageTransactionQuery.php

@@ -7,4 +7,8 @@ final class PhabricatorAuthMessageTransactionQuery
     return new PhabricatorAuthMessageTransaction();
   }
 
+  public function getQueryApplicationClass() {
+    return PhabricatorAuthApplication::class;
+  }
+
 }

src/applications/auth/query/PhabricatorAuthPasswordTransactionQuery.php

@@ -7,4 +7,8 @@ final class PhabricatorAuthPasswordTransactionQuery
     return new PhabricatorAuthPasswordTransaction();
   }
 
+  public function getQueryApplicationClass() {
+    return PhabricatorAuthApplication::class;
+  }
+
 }

src/applications/auth/query/PhabricatorAuthProviderConfigTransactionQuery.php

@@ -7,4 +7,8 @@ final class PhabricatorAuthProviderConfigTransactionQuery
     return new PhabricatorAuthProviderConfigTransaction();
   }
 
+  public function getQueryApplicationClass() {
+    return PhabricatorAuthApplication::class;
+  }
+
 }

src/applications/auth/query/PhabricatorAuthSSHKeyTransactionQuery.php

@@ -7,4 +7,8 @@ final class PhabricatorAuthSSHKeyTransactionQuery
     return new PhabricatorAuthSSHKeyTransaction();
   }
 
+  public function getQueryApplicationClass() {
+    return PhabricatorAuthApplication::class;
+  }
+
 }

src/applications/badges/query/PhabricatorBadgesTransactionQuery.php

@@ -7,4 +7,8 @@ final class PhabricatorBadgesTransactionQuery
     return new PhabricatorBadgesTransaction();
   }
 
+  public function getQueryApplicationClass() {
+    return PhabricatorBadgesApplication::class;
+  }
+
 }

src/applications/calendar/query/PhabricatorCalendarEventTransactionQuery.php

@@ -7,4 +7,8 @@ final class PhabricatorCalendarEventTransactionQuery
     return new PhabricatorCalendarEventTransaction();
   }
 
+  public function getQueryApplicationClass() {
+    return PhabricatorCalendarApplication::class;
+  }
+
 }

src/applications/calendar/query/PhabricatorCalendarExportTransactionQuery.php

@@ -7,4 +7,8 @@ final class PhabricatorCalendarExportTransactionQuery
     return new PhabricatorCalendarExportTransaction();
   }
 
+  public function getQueryApplicationClass() {
+    return PhabricatorCalendarApplication::class;
+  }
+
 }

src/applications/calendar/query/PhabricatorCalendarImportTransactionQuery.php

@@ -7,4 +7,8 @@ final class PhabricatorCalendarImportTransactionQuery
     return new PhabricatorCalendarImportTransaction();
   }
 
+  public function getQueryApplicationClass() {
+    return PhabricatorCalendarApplication::class;
+  }
+
 }

src/applications/config/query/PhabricatorConfigTransactionQuery.php

@@ -7,4 +7,8 @@ final class PhabricatorConfigTransactionQuery
     return new PhabricatorConfigTransaction();
   }
 
+  public function getQueryApplicationClass() {
+    return PhabricatorConfigApplication::class;
+  }
+
 }

src/applications/conpherence/query/ConpherenceTransactionQuery.php

@@ -7,4 +7,8 @@ final class ConpherenceTransactionQuery
     return new ConpherenceTransaction();
   }
 
+  public function getQueryApplicationClass() {
+    return PhabricatorConpherenceApplication::class;
+  }
+
 }

src/applications/countdown/query/PhabricatorCountdownTransactionQuery.php

@@ -7,4 +7,8 @@ final class PhabricatorCountdownTransactionQuery
     return new PhabricatorCountdownTransaction();
   }
 
+  public function getQueryApplicationClass() {
+    return PhabricatorCountdownApplication::class;
+  }
+
 }

src/applications/dashboard/query/PhabricatorDashboardPanelTransactionQuery.php

@@ -7,4 +7,8 @@ final class PhabricatorDashboardPanelTransactionQuery
     return new PhabricatorDashboardPanelTransaction();
   }
 
+  public function getQueryApplicationClass() {
+    return PhabricatorDashboardApplication::class;
+  }
+
 }

src/applications/dashboard/query/PhabricatorDashboardPortalTransactionQuery.php

@@ -7,4 +7,8 @@ final class PhabricatorDashboardPortalTransactionQuery
     return new PhabricatorDashboardPortalTransaction();
   }
 
+  public function getQueryApplicationClass() {
+    return PhabricatorDashboardApplication::class;
+  }
+
 }

src/applications/dashboard/query/PhabricatorDashboardTransactionQuery.php

@@ -7,4 +7,8 @@ final class PhabricatorDashboardTransactionQuery
     return new PhabricatorDashboardTransaction();
   }
 
+  public function getQueryApplicationClass() {
+    return PhabricatorDashboardApplication::class;
+  }
+
 }

src/applications/differential/query/DifferentialDiffTransactionQuery.php

@@ -7,4 +7,8 @@ final class DifferentialDiffTransactionQuery
     return new DifferentialDiffTransaction();
   }
 
+  public function getQueryApplicationClass() {
+    return PhabricatorDifferentialApplication::class;
+  }
+
 }

src/applications/differential/query/DifferentialTransactionQuery.php

@@ -7,4 +7,8 @@ final class DifferentialTransactionQuery
     return new DifferentialTransaction();
   }
 
+  public function getQueryApplicationClass() {
+    return PhabricatorDifferentialApplication::class;
+  }
+
 }

src/applications/diviner/query/DivinerLiveBookTransactionQuery.php

@@ -7,4 +7,8 @@ final class DivinerLiveBookTransactionQuery
     return new DivinerLiveBookTransaction();
   }
 
+  public function getQueryApplicationClass() {
+    return PhabricatorDivinerApplication::class;
+  }
+
 }

src/applications/drydock/query/DrydockBlueprintTransactionQuery.php

@@ -7,4 +7,8 @@ final class DrydockBlueprintTransactionQuery
     return new DrydockBlueprintTransaction();
   }
 
+  public function getQueryApplicationClass() {
+    return PhabricatorDrydockApplication::class;
+  }
+
 }

src/applications/files/query/PhabricatorFileTransactionQuery.php

@@ -7,4 +7,8 @@ final class PhabricatorFileTransactionQuery
     return new PhabricatorFileTransaction();
   }
 
+  public function getQueryApplicationClass() {
+    return PhabricatorFilesApplication::class;
+  }
+
 }

src/applications/fund/query/FundBackerTransactionQuery.php

@@ -7,4 +7,8 @@ final class FundBackerTransactionQuery
     return new FundBackerTransaction();
   }
 
+  public function getQueryApplicationClass() {
+    return PhabricatorFundApplication::class;
+  }
+
 }

src/applications/fund/query/FundInitiativeTransactionQuery.php

@@ -7,4 +7,8 @@ final class FundInitiativeTransactionQuery
     return new FundInitiativeTransaction();
   }
 
+  public function getQueryApplicationClass() {
+    return PhabricatorFundApplication::class;
+  }
+
 }

src/applications/harbormaster/query/HarbormasterBuildPlanTransactionQuery.php

@@ -7,4 +7,8 @@ final class HarbormasterBuildPlanTransactionQuery
     return new HarbormasterBuildPlanTransaction();
   }
 
+  public function getQueryApplicationClass() {
+    return PhabricatorHarbormasterApplication::class;
+  }
+
 }

src/applications/harbormaster/query/HarbormasterBuildStepTransactionQuery.php

@@ -7,4 +7,8 @@ final class HarbormasterBuildStepTransactionQuery
     return new HarbormasterBuildStepTransaction();
   }
 
+  public function getQueryApplicationClass() {
+    return PhabricatorHarbormasterApplication::class;
+  }
+
 }

src/applications/harbormaster/query/HarbormasterBuildTransactionQuery.php

@@ -7,4 +7,8 @@ final class HarbormasterBuildTransactionQuery
     return new HarbormasterBuildTransaction();
   }
 
+  public function getQueryApplicationClass() {
+    return PhabricatorHarbormasterApplication::class;
+  }
+
 }

src/applications/harbormaster/query/HarbormasterBuildableTransactionQuery.php

@@ -7,4 +7,8 @@ final class HarbormasterBuildableTransactionQuery
     return new HarbormasterBuildableTransaction();
   }
 
+  public function getQueryApplicationClass() {
+    return PhabricatorHarbormasterApplication::class;
+  }
+
 }

src/applications/herald/query/HeraldTransactionQuery.php

@@ -7,4 +7,8 @@ final class HeraldTransactionQuery
     return new HeraldRuleTransaction();
   }
 
+  public function getQueryApplicationClass() {
+    return PhabricatorHeraldApplication::class;
+  }
+
 }

src/applications/herald/query/HeraldWebhookTransactionQuery.php

@@ -7,4 +7,8 @@ final class HeraldWebhookTransactionQuery
     return new HeraldWebhookTransaction();
   }
 
+  public function getQueryApplicationClass() {
+    return PhabricatorHeraldApplication::class;
+  }
+
 }

src/applications/legalpad/query/LegalpadTransactionQuery.php

@@ -7,4 +7,8 @@ final class LegalpadTransactionQuery
     return new LegalpadTransaction();
   }
 
+  public function getQueryApplicationClass() {
+    return PhabricatorLegalpadApplication::class;
+  }
+
 }

src/applications/macro/query/PhabricatorMacroTransactionQuery.php

@@ -7,4 +7,8 @@ final class PhabricatorMacroTransactionQuery
     return new PhabricatorMacroTransaction();
   }
 
+  public function getQueryApplicationClass() {
+    return PhabricatorMacroApplication::class;
+  }
+
 }

src/applications/maniphest/query/ManiphestTransactionQuery.php

@@ -7,4 +7,8 @@ final class ManiphestTransactionQuery
     return new ManiphestTransaction();
   }
 
+  public function getQueryApplicationClass() {
+    return PhabricatorManiphestApplication::class;
+  }
+
 }

src/applications/meta/query/PhabricatorApplicationApplicationTransactionQuery.php

@@ -7,4 +7,11 @@ final class PhabricatorApplicationApplicationTransactionQuery
     return new PhabricatorApplicationApplicationTransaction();
   }
 
+  // NOTE: Although this belongs to the "Applications" application, trying
+  // to filter its results just leaves us recursing indefinitely. Users
+  // always have access to applications regardless of other policy settings
+  // anyway.
+  public function getQueryApplicationClass() {
+    return null;
+  }
 }

src/applications/metamta/query/PhabricatorMetaMTAApplicationEmailTransactionQuery.php

@@ -7,4 +7,8 @@ final class PhabricatorMetaMTAApplicationEmailTransactionQuery
     return new PhabricatorMetaMTAApplicationEmailTransaction();
   }
 
+  public function getQueryApplicationClass() {
+    return PhabricatorMetaMTAApplication::class;
+  }
+
 }

src/applications/nuance/query/NuanceItemTransactionQuery.php

@@ -7,4 +7,8 @@ final class NuanceItemTransactionQuery
     return new NuanceItemTransaction();
   }
 
+  public function getQueryApplicationClass() {
+    return PhabricatorNuanceApplication::class;
+  }
+
 }

src/applications/nuance/query/NuanceQueueTransactionQuery.php

@@ -7,4 +7,8 @@ final class NuanceQueueTransactionQuery
     return new NuanceQueueTransaction();
   }
 
+  public function getQueryApplicationClass() {
+    return PhabricatorNuanceApplication::class;
+  }
+
 }

src/applications/nuance/query/NuanceSourceTransactionQuery.php

@@ -7,4 +7,8 @@ final class NuanceSourceTransactionQuery
     return new NuanceSourceTransaction();
   }
 
+  public function getQueryApplicationClass() {
+    return PhabricatorNuanceApplication::class;
+  }
+
 }

src/applications/oauthserver/query/PhabricatorOAuthServerTransactionQuery.php

@@ -7,4 +7,8 @@ final class PhabricatorOAuthServerTransactionQuery
     return new PhabricatorOAuthServerTransaction();
   }
 
+  public function getQueryApplicationClass() {
+    return PhabricatorOAuthServerApplication::class;
+  }
+
 }

src/applications/owners/query/PhabricatorOwnersPackageTransactionQuery.php

@@ -7,4 +7,8 @@ final class PhabricatorOwnersPackageTransactionQuery
     return new PhabricatorOwnersPackageTransaction();
   }
 
+  public function getQueryApplicationClass() {
+    return PhabricatorOwnersApplication::class;
+  }
+
 }

src/applications/packages/query/PhabricatorPackagesPackageTransactionQuery.php

@@ -7,4 +7,8 @@ final class PhabricatorPackagesPackageTransactionQuery
     return new PhabricatorPackagesPackageTransaction();
   }
 
+  public function getQueryApplicationClass() {
+    return PhabricatorPackagesApplication::class;
+  }
+
 }

src/applications/packages/query/PhabricatorPackagesPublisherTransactionQuery.php

@@ -7,4 +7,8 @@ final class PhabricatorPackagesPublisherTransactionQuery
     return new PhabricatorPackagesPublisherTransaction();
   }
 
+  public function getQueryApplicationClass() {
+    return PhabricatorPackagesApplication::class;
+  }
+
 }

src/applications/packages/query/PhabricatorPackagesVersionTransactionQuery.php

@@ -7,4 +7,8 @@ final class PhabricatorPackagesVersionTransactionQuery
     return new PhabricatorPackagesVersionTransaction();
   }
 
+  public function getQueryApplicationClass() {
+    return PhabricatorPackagesApplication::class;
+  }
+
 }

src/applications/passphrase/query/PassphraseCredentialTransactionQuery.php

@@ -7,4 +7,8 @@ final class PassphraseCredentialTransactionQuery
     return new PassphraseCredentialTransaction();
   }
 
+  public function getQueryApplicationClass() {
+    return PhabricatorPassphraseApplication::class;
+  }
+
 }

src/applications/paste/query/PhabricatorPasteTransactionQuery.php

@@ -7,4 +7,8 @@ final class PhabricatorPasteTransactionQuery
     return new PhabricatorPasteTransaction();
   }
 
+  public function getQueryApplicationClass() {
+    return PhabricatorPasteApplication::class;
+  }
+
 }

src/applications/people/query/PhabricatorPeopleTransactionQuery.php

@@ -7,4 +7,8 @@ final class PhabricatorPeopleTransactionQuery
     return new PhabricatorUserTransaction();
   }
 
+  public function getQueryApplicationClass() {
+    return PhabricatorPeopleApplication::class;
+  }
+
 }

src/applications/phame/query/PhameBlogTransactionQuery.php

@@ -7,4 +7,8 @@ final class PhameBlogTransactionQuery
     return new PhameBlogTransaction();
   }
 
+  public function getQueryApplicationClass() {
+    return PhabricatorPhameApplication::class;
+  }
+
 }

src/applications/phame/query/PhamePostTransactionQuery.php

@@ -7,4 +7,8 @@ final class PhamePostTransactionQuery
     return new PhamePostTransaction();
   }
 
+  public function getQueryApplicationClass() {
+    return PhabricatorPhameApplication::class;
+  }
+
 }

src/applications/phlux/query/PhluxTransactionQuery.php

@@ -7,4 +7,8 @@ final class PhluxTransactionQuery
     return new PhluxTransaction();
   }
 
+  public function getQueryApplicationClass() {
+    return PhabricatorPhluxApplication::class;
+  }
+
 }

src/applications/pholio/query/PholioTransactionQuery.php

@@ -7,4 +7,8 @@ final class PholioTransactionQuery
     return new PholioTransaction();
   }
 
+  public function getQueryApplicationClass() {
+    return PhabricatorPholioApplication::class;
+  }
+
 }

src/applications/phortune/query/PhortuneAccountEmailTransactionQuery.php

@@ -7,4 +7,8 @@ final class PhortuneAccountEmailTransactionQuery
     return new PhortuneAccountEmailTransaction();
   }
 
+  public function getQueryApplicationClass() {
+    return PhabricatorPhortuneApplication::class;
+  }
+
 }

src/applications/phortune/query/PhortuneAccountTransactionQuery.php

@@ -7,4 +7,8 @@ final class PhortuneAccountTransactionQuery
     return new PhortuneAccountTransaction();
   }
 
+  public function getQueryApplicationClass() {
+    return PhabricatorPhortuneApplication::class;
+  }
+
 }

src/applications/phortune/query/PhortuneCartTransactionQuery.php

@@ -7,4 +7,8 @@ final class PhortuneCartTransactionQuery
     return new PhortuneCartTransaction();
   }
 
+  public function getQueryApplicationClass() {
+    return PhabricatorPhortuneApplication::class;
+  }
+
 }

src/applications/phortune/query/PhortuneMerchantTransactionQuery.php

@@ -7,4 +7,8 @@ final class PhortuneMerchantTransactionQuery
     return new PhortuneMerchantTransaction();
   }
 
+  public function getQueryApplicationClass() {
+    return PhabricatorPhortuneApplication::class;
+  }
+
 }

src/applications/phortune/query/PhortunePaymentMethodTransactionQuery.php

@@ -7,4 +7,8 @@ final class PhortunePaymentMethodTransactionQuery
     return new PhortunePaymentMethodTransaction();
   }
 
+  public function getQueryApplicationClass() {
+    return PhabricatorPhortuneApplication::class;
+  }
+
 }

src/applications/phortune/query/PhortunePaymentProviderConfigTransactionQuery.php

@@ -7,4 +7,8 @@ final class PhortunePaymentProviderConfigTransactionQuery
     return new PhortunePaymentProviderConfigTransaction();
   }
 
+  public function getQueryApplicationClass() {
+    return PhabricatorPhortuneApplication::class;
+  }
+
 }

src/applications/phortune/query/PhortuneSubscriptionTransactionQuery.php

@@ -7,4 +7,8 @@ final class PhortuneSubscriptionTransactionQuery
     return new PhortuneSubscriptionTransaction();
   }
 
+  public function getQueryApplicationClass() {
+    return PhabricatorPhortuneApplication::class;
+  }
+
 }

src/applications/phriction/query/PhrictionTransactionQuery.php

@@ -7,4 +7,8 @@ final class PhrictionTransactionQuery
     return new PhrictionTransaction();
   }
 
+  public function getQueryApplicationClass() {
+    return PhabricatorPhrictionApplication::class;
+  }
+
 }

src/applications/phurl/query/PhabricatorPhurlURLTransactionQuery.php

@@ -7,4 +7,8 @@ final class PhabricatorPhurlURLTransactionQuery
     return new PhabricatorPhurlURLTransaction();
   }
 
+  public function getQueryApplicationClass() {
+    return PhabricatorPhurlApplication::class;
+  }
+
 }

src/applications/ponder/query/PonderAnswerTransactionQuery.php

@@ -7,4 +7,8 @@ final class PonderAnswerTransactionQuery
     return new PonderAnswerTransaction();
   }
 
+  public function getQueryApplicationClass() {
+    return PhabricatorPonderApplication::class;
+  }
+
 }

src/applications/ponder/query/PonderQuestionTransactionQuery.php

@@ -7,4 +7,8 @@ final class PonderQuestionTransactionQuery
     return new PonderQuestionTransaction();
   }
 
+  public function getQueryApplicationClass() {
+    return PhabricatorPonderApplication::class;
+  }
+
 }

src/applications/project/query/PhabricatorProjectColumnTransactionQuery.php

@@ -7,4 +7,8 @@ final class PhabricatorProjectColumnTransactionQuery
     return new PhabricatorProjectColumnTransaction();
   }
 
+  public function getQueryApplicationClass() {
+    return PhabricatorProjectApplication::class;
+  }
+
 }

src/applications/project/query/PhabricatorProjectTransactionQuery.php

@@ -7,4 +7,8 @@ final class PhabricatorProjectTransactionQuery
     return new PhabricatorProjectTransaction();
   }
 
+  public function getQueryApplicationClass() {
+    return PhabricatorProjectApplication::class;
+  }
+
 }

src/applications/project/query/PhabricatorProjectTriggerTransactionQuery.php

@@ -7,4 +7,8 @@ final class PhabricatorProjectTriggerTransactionQuery
     return new PhabricatorProjectTriggerTransaction();
   }
 
+  public function getQueryApplicationClass() {
+    return PhabricatorProjectApplication::class;
+  }
+
 }

src/applications/repository/query/PhabricatorRepositoryIdentityTransactionQuery.php

@@ -7,4 +7,8 @@ final class PhabricatorRepositoryIdentityTransactionQuery
     return new PhabricatorRepositoryIdentityTransaction();
   }
 
+  public function getQueryApplicationClass() {
+    return PhabricatorDiffusionApplication::class;
+  }
+
 }

src/applications/repository/query/PhabricatorRepositoryTransactionQuery.php

@@ -7,4 +7,8 @@ final class PhabricatorRepositoryTransactionQuery
     return new PhabricatorRepositoryTransaction();
   }
 
+  public function getQueryApplicationClass() {
+    return PhabricatorDiffusionApplication::class;
+  }
+
 }

src/applications/repository/query/PhabricatorRepositoryURITransactionQuery.php

@@ -7,4 +7,8 @@ final class PhabricatorRepositoryURITransactionQuery
     return new PhabricatorRepositoryURITransaction();
   }
 
+  public function getQueryApplicationClass() {
+    return PhabricatorDiffusionApplication::class;
+  }
+
 }

src/applications/search/query/PhabricatorProfileMenuItemConfigurationTransactionQuery.php

@@ -7,4 +7,8 @@ final class PhabricatorProfileMenuItemConfigurationTransactionQuery
     return new PhabricatorProfileMenuItemConfigurationTransaction();
   }
 
+  public function getQueryApplicationClass() {
+    return PhabricatorSearchApplication::class;
+  }
+
 }

src/applications/settings/query/PhabricatorUserPreferencesTransactionQuery.php

@@ -7,4 +7,8 @@ final class PhabricatorUserPreferencesTransactionQuery
     return new PhabricatorUserPreferencesTransaction();
   }
 
+  public function getQueryApplicationClass() {
+    return PhabricatorSettingsApplication::class;
+  }
+
 }

src/applications/slowvote/query/PhabricatorSlowvoteTransactionQuery.php

@@ -7,4 +7,8 @@ final class PhabricatorSlowvoteTransactionQuery
     return new PhabricatorSlowvoteTransaction();
   }
 
+  public function getQueryApplicationClass() {
+    return PhabricatorSlowvoteApplication::class;
+  }
+
 }

src/applications/spaces/query/PhabricatorSpacesNamespaceTransactionQuery.php

@@ -7,4 +7,8 @@ final class PhabricatorSpacesNamespaceTransactionQuery
     return new PhabricatorSpacesNamespaceTransaction();
   }
 
+  public function getQueryApplicationClass() {
+    return PhabricatorSpacesApplication::class;
+  }
+
 }

src/applications/transactions/query/PhabricatorApplicationTransactionQuery.php

@@ -292,8 +292,14 @@ abstract class PhabricatorApplicationTransactionQuery
     return parent::shouldGroupQueryResultRows();
   }
 
+  /**
+   * Get name of class of application queried by the query.
+   *
+   * To be overwritten by child classes when applicable.
+   *
+   * @return  string|null Application class name
+   */
   public function getQueryApplicationClass() {
-    // TODO: Sort this out?
     return null;
   }
 

src/applications/transactions/query/PhabricatorEditEngineConfigurationTransactionQuery.php

@@ -7,4 +7,8 @@ final class PhabricatorEditEngineConfigurationTransactionQuery
     return new PhabricatorEditEngineConfigurationTransaction();
   }
 
+  public function getQueryApplicationClass() {
+    return PhabricatorTransactionsApplication::class;
+  }
+
 }

src/infrastructure/daemon/workers/query/PhabricatorWorkerBulkJobTransactionQuery.php

@@ -7,4 +7,8 @@ final class PhabricatorWorkerBulkJobTransactionQuery
     return new PhabricatorWorkerBulkJobTransaction();
   }
 
+  public function getQueryApplicationClass() {
+    return PhabricatorDaemonsApplication::class;
+  }
+
 }