revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-09-20 09:18:48 +02:00
Code Issues Releases Wiki Activity

Allow tall two-column/curtain headers to be triple-clicked in Firefox

Browse source 
Summary:
Fixes T10905. In Firefox, triple clicking the new headers doesn't select the entire line, so you can't easily copy/paste an entire task title or revision name. It works fine in Safari/Chrome.

This seems to fix that without breaking anything.

Test Plan:
  - Viewed headers in Safari, Firefox, Chrome.
  - Triple-clicked headers in Safari, Firefox, Chrome.
  - Viewed tablet/device layouts in Safari, Firefox, Chrome.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T10905

Differential Revision: https://secure.phabricator.com/D15823
This commit is contained in:
epriestley 2016-04-29 16:37:45 -07:00
parent c314a3672f
commit 06abeb2010
3 changed files with 16 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
resources/celerity/map.php
View file

@ -7,7 +7,7 @@
*/ */
return array( return array(
'names' => array( 'names' => array(
'core.pkg.css' => '04a95108', 'core.pkg.css' => 'ede6bf7a',
'core.pkg.js' => '6972d365', 'core.pkg.js' => '6972d365',
'darkconsole.pkg.js' => 'e7393ebb', 'darkconsole.pkg.js' => 'e7393ebb',
'differential.pkg.css' => '7ba78475', 'differential.pkg.css' => '7ba78475',
@ -136,7 +136,7 @@ return array(
'rsrc/css/phui/phui-form-view.css' => '6a51768e', 'rsrc/css/phui/phui-form-view.css' => '6a51768e',
'rsrc/css/phui/phui-form.css' => 'aac1d51d', 'rsrc/css/phui/phui-form.css' => 'aac1d51d',
'rsrc/css/phui/phui-head-thing.css' => 'fd311e5f', 'rsrc/css/phui/phui-head-thing.css' => 'fd311e5f',
'rsrc/css/phui/phui-header-view.css' => '230254d3', 'rsrc/css/phui/phui-header-view.css' => '9961e480',
'rsrc/css/phui/phui-hovercard.css' => 'de1a2119', 'rsrc/css/phui/phui-hovercard.css' => 'de1a2119',
'rsrc/css/phui/phui-icon-set-selector.css' => '1ab67aad', 'rsrc/css/phui/phui-icon-set-selector.css' => '1ab67aad',
'rsrc/css/phui/phui-icon.css' => '3f33ab57', 'rsrc/css/phui/phui-icon.css' => '3f33ab57',
@ -829,7 +829,7 @@ return array(
'phui-form-css' => 'aac1d51d', 'phui-form-css' => 'aac1d51d',
'phui-form-view-css' => '6a51768e', 'phui-form-view-css' => '6a51768e',
'phui-head-thing-view-css' => 'fd311e5f', 'phui-head-thing-view-css' => 'fd311e5f',
'phui-header-view-css' => '230254d3', 'phui-header-view-css' => '9961e480',
'phui-hovercard' => '1bd28176', 'phui-hovercard' => '1bd28176',
'phui-hovercard-view-css' => 'de1a2119', 'phui-hovercard-view-css' => 'de1a2119',
'phui-icon-set-selector-css' => '1ab67aad', 'phui-icon-set-selector-css' => '1ab67aad',

9
src/view/phui/PHUIHeaderView.php
View file

@ -316,6 +316,15 @@ final class PHUIHeaderView extends AphrontTagView {
$header_content); $header_content);
} }
// This wrapper element allows titles to be triple-clicked to select them
// in Firefox. See T10905 for discussion.
$header_content = phutil_tag(
'span',
array(
'class' => 'phui-header-content',
),
$header_content);
$left[] = phutil_tag( $left[] = phutil_tag(
'span', 'span',
array( array(

4
webroot/rsrc/css/phui/phui-header-view.css
View file

@ -80,6 +80,10 @@ body .phui-header-shell.phui-bleed-header
color: {$lightbluetext}; color: {$lightbluetext};
} }
.phui-header-content {
display: inline-block;
}
.phui-object-box .phui-header-tall .phui-header-header, .phui-object-box .phui-header-tall .phui-header-header,
.phui-document-view .phui-header-tall .phui-header-header { .phui-document-view .phui-header-tall .phui-header-header {
font-size: 18px; font-size: 18px;