revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-20 05:42:40 +01:00
Code Issues Releases Wiki Activity

Remove backticks from SQL statements

Browse source 
Summary: Remove backticks from SQL statements for consistency. In //most// places, we don't use backticks around table/field names, so at least be consistent about this.

Test Plan: Learned what backticks are used for in MySQL.

Reviewers: eadler, epriestley, #blessed_reviewers

Reviewed By: eadler, epriestley, #blessed_reviewers

Subscribers: epriestley

Differential Revision: https://secure.phabricator.com/D13267
This commit is contained in:
Joshua Spence 2015-06-15 07:38:28 +10:00
parent 69a9b5c3a3
commit 070da82864
3 changed files with 6 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/applications/herald/garbagecollector/HeraldTranscriptGarbageCollector.php
View file

@ -20,7 +20,7 @@ final class HeraldTranscriptGarbageCollector
conditionTranscripts = "",
applyTranscripts = "",
garbageCollected = 1
WHERE garbageCollected = 0 AND `time` < %d
WHERE garbageCollected = 0 AND time < %d
LIMIT 100',
$table->getTableName(),
time() - $ttl);

4
src/applications/ponder/editor/PonderVoteEditor.php
View file

@ -63,8 +63,8 @@ final class PonderVoteEditor extends PhabricatorEditor {
queryfx($conn,
'UPDATE %T as t
SET t.`voteCount` = t.`voteCount` + %d
WHERE t.`PHID` = %s',
SET t.voteCount = t.voteCount + %d
WHERE t.PHID = %s',
$votable->getTableName(),
$delta,
$votable->getVotablePHID());

6
src/applications/xhprof/controller/PhabricatorXHProfSampleListController.php
View file

@ -18,18 +18,18 @@ final class PhabricatorXHProfSampleListController
switch ($this->view) {
case 'sampled':
$clause = '`sampleRate` > 0';
$clause = 'sampleRate > 0';
$show_type = false;
break;
case 'my-runs':
$clause = qsprintf(
id(new PhabricatorXHProfSample())->establishConnection('r'),
'`sampleRate` = 0 AND `userPHID` = %s',
'sampleRate = 0 AND userPHID = %s',
$request->getUser()->getPHID());
$show_type = false;
break;
case 'manual':
$clause = '`sampleRate` = 0';
$clause = 'sampleRate = 0';
$show_type = false;
break;
case 'all':