Define diff as a local variable

Summary: This should be a local variable, not a global variable. This silences a few JSHint warnings.

Test Plan: `arc lint`

Reviewers: epriestley, #blessed_reviewers

Reviewed By: epriestley, #blessed_reviewers

Subscribers: Korvin, epriestley

Differential Revision: https://secure.phabricator.com/D11070

resources/celerity/map.php

@@ -11,7 +11,7 @@ return array(
     'core.pkg.js' => '44aac665',
     'darkconsole.pkg.js' => 'd326843f',
     'differential.pkg.css' => '8af45893',
-    'differential.pkg.js' => '42c10e78',
+    'differential.pkg.js' => 'dad3622f',
     'diffusion.pkg.css' => '591664fa',
     'diffusion.pkg.js' => 'bfc0737b',
     'maniphest.pkg.css' => 'e34dfbec',
@@ -359,7 +359,7 @@ return array(
     'rsrc/js/application/differential/behavior-comment-jump.js' => '4fdb476d',
     'rsrc/js/application/differential/behavior-comment-preview.js' => '6932def3',
     'rsrc/js/application/differential/behavior-diff-radios.js' => 'e1ff79b1',
-    'rsrc/js/application/differential/behavior-dropdown-menus.js' => '710f209e',
+    'rsrc/js/application/differential/behavior-dropdown-menus.js' => '3bc14668',
     'rsrc/js/application/differential/behavior-edit-inline-comments.js' => '00861799',
     'rsrc/js/application/differential/behavior-keyboard-nav.js' => '2c426492',
     'rsrc/js/application/differential/behavior-populate.js' => 'bdb3e4d0',
@@ -562,7 +562,7 @@ return array(
     'javelin-behavior-differential-add-reviewers-and-ccs' => 'e10f8e18',
     'javelin-behavior-differential-comment-jump' => '4fdb476d',
     'javelin-behavior-differential-diff-radios' => 'e1ff79b1',
-    'javelin-behavior-differential-dropdown-menus' => '710f209e',
+    'javelin-behavior-differential-dropdown-menus' => '3bc14668',
     'javelin-behavior-differential-edit-inline-comments' => '00861799',
     'javelin-behavior-differential-feedback-preview' => '6932def3',
     'javelin-behavior-differential-keyboard-navigation' => '2c426492',
@@ -1003,6 +1003,18 @@ return array(
       'javelin-dom',
       'javelin-magical-init',
     ),
+    '3bc14668' => array(
+      'javelin-behavior',
+      'javelin-dom',
+      'javelin-util',
+      'javelin-stratcom',
+      'javelin-workflow',
+      'phuix-dropdown-menu',
+      'phuix-action-list-view',
+      'phuix-action-view',
+      'phabricator-phtize',
+      'changeset-view-manager',
+    ),
     '3d51a746' => array(
       'javelin-behavior',
       'javelin-dom',
@@ -1212,18 +1224,6 @@ return array(
       'javelin-util',
       'javelin-stratcom',
     ),
-    '710f209e' => array(
-      'javelin-behavior',
-      'javelin-dom',
-      'javelin-util',
-      'javelin-stratcom',
-      'javelin-workflow',
-      'phuix-dropdown-menu',
-      'phuix-action-list-view',
-      'phuix-action-view',
-      'phabricator-phtize',
-      'changeset-view-manager',
-    ),
     '724b1247' => array(
       'javelin-behavior',
       'javelin-typeahead-ondemand-source',

webroot/rsrc/js/application/differential/behavior-dropdown-menus.js

@@ -229,7 +229,7 @@ JX.behavior('differential-dropdown-menus', function(config) {
           'More than one node with sigil "differential-diff" was found in "'+
           data.containerID+'."');
       } else if (diffs.length == 1) {
-        diff = diffs[0];
+        var diff = diffs[0];
         visible_item.setDisabled(false);
         if (JX.Stratcom.getData(diff).hidden) {
           visible_item