From 088dfdb586df74a2b73a4841a52f028e00e6a38a Mon Sep 17 00:00:00 2001 From: epriestley Date: Thu, 20 Feb 2020 12:39:12 -0800 Subject: [PATCH] (stable) Whitelist "vscode://" as an allowed Editor protocol Summary: See PHI1647, which asks for "vscode://" to be a configurable protocol on hosted Phacility instances. I made the configuration editable in D21008, but this can reasonably just come upstream too. Test Plan: Viewed config in Config, set my editor URI to `vscode://blahblah`. Differential Revision: https://secure.phabricator.com/D21009 --- .../config/option/PhabricatorSecurityConfigOptions.php | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/applications/config/option/PhabricatorSecurityConfigOptions.php b/src/applications/config/option/PhabricatorSecurityConfigOptions.php index d5557e3688..b71de40773 100644 --- a/src/applications/config/option/PhabricatorSecurityConfigOptions.php +++ b/src/applications/config/option/PhabricatorSecurityConfigOptions.php @@ -210,6 +210,9 @@ EOTEXT // This isn't a standard handler installed by an application, but // is a reasonable name for a user-installed handler. 'editor' => true, + + // This handler is for Visual Studio Code. + 'vscode' => true, )) ->setSummary(pht('Whitelists editor protocols for "Open in Editor".')) ->setDescription(