mirror of
https://we.phorge.it/source/phorge.git
synced 2024-11-10 08:52:39 +01:00
Remove redundant administrator requirement from application edit policy page
Summary: Fixes T7485. Before applications had proper policies, we gated access by requiring the viewer be an administrator. This is now redundant (CAN_EDIT on applications has the same effect, and performs the same check), and may some day be wrong (we might let administrators configure a different policy to control who can configure applications). Today, it gets the policy dialog wrong. Test Plan: Clicked "Edit Policies" as a non-administrator, was unable to, got nice error: {F346598} Reviewers: btrahan Reviewed By: btrahan Subscribers: epriestley Maniphest Tasks: T7485 Differential Revision: https://secure.phabricator.com/D12125
This commit is contained in:
parent
c7dc59f9c4
commit
08aefafef7
1 changed files with 0 additions and 4 deletions
|
@ -3,10 +3,6 @@
|
|||
final class PhabricatorApplicationEditController
|
||||
extends PhabricatorApplicationsController {
|
||||
|
||||
public function shouldRequireAdmin() {
|
||||
return true;
|
||||
}
|
||||
|
||||
public function handleRequest(AphrontRequest $request) {
|
||||
$user = $request->getUser();
|
||||
$application = $request->getURIData('application');
|
||||
|
|
Loading…
Reference in a new issue