revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-01 03:02:43 +01:00
Code Issues Releases Wiki Activity

(stable) Fix one more "Reviewers" wire format issue

Browse source 
Summary: Fixes T11010. This also needs to be inflated until we fix the whole client/server responsibility issue here.

Test Plan:
  - Created a revision while observing error log, no error.
  - Disabled "allow self accept", tried to make myself a reviewer, got rejected with an error message.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T11010

Differential Revision: https://secure.phabricator.com/D15966
This commit is contained in:
epriestley 2016-05-23 10:42:05 -07:00
parent 77d543ba44
commit 08cc80cc5c
1 changed files with 1 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
src/applications/differential/customfield/DifferentialReviewersField.php
View file

@ -242,6 +242,7 @@ final class DifferentialReviewersField
$config_self_accept_key = 'differential.allow-self-accept'; $config_self_accept_key = 'differential.allow-self-accept';
$allow_self_accept = PhabricatorEnv::getEnvConfig($config_self_accept_key); $allow_self_accept = PhabricatorEnv::getEnvConfig($config_self_accept_key);
$value = $this->inflateReviewers($value);
foreach ($value as $spec) { foreach ($value as $spec) {
$phid = $spec['phid']; $phid = $spec['phid'];