From 08ec0f1704d903cc596c4209bdf5206f1e3f486a Mon Sep 17 00:00:00 2001
From: Chad Little <chad@phacility.com>
Date: Mon, 29 Jun 2015 12:28:55 -0700
Subject: [PATCH] [Redesign] Remove AphrontTable restriction on Search Engine

Summary: Ref T8099, functionally I prefer to be able to set anything 'table-like' with `setTable` for design consistency. This looses the restriction and did some light grepping for other missed cases.

Test Plan: Test new UI, grep for other missing cases.

Reviewers: btrahan, epriestley

Reviewed By: epriestley

Subscribers: epriestley, Korvin

Maniphest Tasks: T8099

Differential Revision: https://secure.phabricator.com/D13471
---
 .../controller/HarbormasterBuildableViewController.php        | 4 ++--
 .../controller/HarbormasterUnitMessagesController.php         | 2 +-
 .../owners/controller/PhabricatorOwnersDetailController.php   | 2 +-
 .../people/query/PhabricatorPeopleLogSearchEngine.php         | 3 +--
 .../query/PhabricatorRepositoryPushLogSearchEngine.php        | 4 ++--
 .../search/view/PhabricatorApplicationSearchResultView.php    | 2 +-
 6 files changed, 8 insertions(+), 9 deletions(-)

diff --git a/src/applications/harbormaster/controller/HarbormasterBuildableViewController.php b/src/applications/harbormaster/controller/HarbormasterBuildableViewController.php
index 634a3b0dc4..ac55bf40b0 100644
--- a/src/applications/harbormaster/controller/HarbormasterBuildableViewController.php
+++ b/src/applications/harbormaster/controller/HarbormasterBuildableViewController.php
@@ -303,7 +303,7 @@ final class HarbormasterBuildableViewController
 
       $lint = id(new PHUIObjectBoxView())
         ->setHeader($lint_header)
-        ->appendChild($lint_table);
+        ->setTable($lint_table);
     } else {
       $lint = null;
     }
@@ -327,7 +327,7 @@ final class HarbormasterBuildableViewController
 
       $unit = id(new PHUIObjectBoxView())
         ->setHeader($unit_header)
-        ->appendChild($unit_table);
+        ->setTable($unit_table);
     } else {
       $unit = null;
     }
diff --git a/src/applications/harbormaster/controller/HarbormasterUnitMessagesController.php b/src/applications/harbormaster/controller/HarbormasterUnitMessagesController.php
index cf56f8e4d3..ada83f9a5a 100644
--- a/src/applications/harbormaster/controller/HarbormasterUnitMessagesController.php
+++ b/src/applications/harbormaster/controller/HarbormasterUnitMessagesController.php
@@ -40,7 +40,7 @@ final class HarbormasterUnitMessagesController
 
     $unit = id(new PHUIObjectBoxView())
       ->setHeaderText(pht('Unit Tests'))
-      ->appendChild($unit_table);
+      ->setTable($unit_table);
 
     $crumbs = $this->buildApplicationCrumbs();
     $this->addBuildableCrumb($crumbs, $buildable);
diff --git a/src/applications/owners/controller/PhabricatorOwnersDetailController.php b/src/applications/owners/controller/PhabricatorOwnersDetailController.php
index 7935031389..6ec31eadfc 100644
--- a/src/applications/owners/controller/PhabricatorOwnersDetailController.php
+++ b/src/applications/owners/controller/PhabricatorOwnersDetailController.php
@@ -276,7 +276,7 @@ final class PhabricatorOwnersDetailController
 
     $box = id(new PHUIObjectBoxView())
       ->setHeaderText(pht('Paths'))
-      ->appendChild($table);
+      ->setTable($table);
 
     if ($info) {
       $box->setInfoView($info);
diff --git a/src/applications/people/query/PhabricatorPeopleLogSearchEngine.php b/src/applications/people/query/PhabricatorPeopleLogSearchEngine.php
index fd64142c1e..851ef113d0 100644
--- a/src/applications/people/query/PhabricatorPeopleLogSearchEngine.php
+++ b/src/applications/people/query/PhabricatorPeopleLogSearchEngine.php
@@ -187,8 +187,7 @@ final class PhabricatorPeopleLogSearchEngine
     }
 
     $result = new PhabricatorApplicationSearchResultView();
-    $result->setContent($table);
-    $result->setCollapsed(true);
+    $result->setTable($table);
 
     return $result;
   }
diff --git a/src/applications/repository/query/PhabricatorRepositoryPushLogSearchEngine.php b/src/applications/repository/query/PhabricatorRepositoryPushLogSearchEngine.php
index ac798975ac..b054423d26 100644
--- a/src/applications/repository/query/PhabricatorRepositoryPushLogSearchEngine.php
+++ b/src/applications/repository/query/PhabricatorRepositoryPushLogSearchEngine.php
@@ -103,13 +103,13 @@ final class PhabricatorRepositoryPushLogSearchEngine
     PhabricatorSavedQuery $query,
     array $handles) {
 
-    $content = id(new DiffusionPushLogListView())
+    $table = id(new DiffusionPushLogListView())
       ->setUser($this->requireViewer())
       ->setHandles($handles)
       ->setLogs($logs);
 
     return id(new PhabricatorApplicationSearchResultView())
-      ->setContent($content);
+      ->setTable($table);
   }
 
 }
diff --git a/src/applications/search/view/PhabricatorApplicationSearchResultView.php b/src/applications/search/view/PhabricatorApplicationSearchResultView.php
index 729b6833bd..a6b8aa3b8b 100644
--- a/src/applications/search/view/PhabricatorApplicationSearchResultView.php
+++ b/src/applications/search/view/PhabricatorApplicationSearchResultView.php
@@ -34,7 +34,7 @@ final class PhabricatorApplicationSearchResultView extends Phobject {
     return $list;
   }
 
-  public function setTable(AphrontTableView $table) {
+  public function setTable($table) {
     $this->table = $table;
     return $this;
   }