mirror of
https://we.phorge.it/source/phorge.git
synced 2024-12-19 20:10:55 +01:00
Clean up Macro view page
Summary: Sets a header icon, makes "Details" not show if empty, simplifies title. Test Plan: Review a few Macro pages for changes with and without audio. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Differential Revision: https://secure.phabricator.com/D15406
This commit is contained in:
parent
010b7811b4
commit
090252a89e
1 changed files with 7 additions and 2 deletions
|
@ -40,7 +40,8 @@ final class PhabricatorMacroViewController
|
|||
$header = id(new PHUIHeaderView())
|
||||
->setUser($viewer)
|
||||
->setPolicyObject($macro)
|
||||
->setHeader($title_long);
|
||||
->setHeader($macro->getName())
|
||||
->setHeaderIcon('fa-file-image-o');
|
||||
|
||||
if (!$macro->getIsDisabled()) {
|
||||
$header->setStatus('fa-check', 'bluegrey', pht('Active'));
|
||||
|
@ -177,7 +178,11 @@ final class PhabricatorMacroViewController
|
|||
$viewer->renderHandle($audio_phid));
|
||||
}
|
||||
|
||||
return $view;
|
||||
if ($view->hasAnyProperties()) {
|
||||
return $view;
|
||||
}
|
||||
|
||||
return null;
|
||||
}
|
||||
|
||||
private function buildFileView(
|
||||
|
|
Loading…
Reference in a new issue