revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-24 06:20:56 +01:00
Code Issues Releases Wiki Activity

Clean up Macro view page

Browse source 
Summary: Sets a header icon, makes "Details" not show if empty, simplifies title.

Test Plan: Review a few Macro pages for changes with and without audio.

Reviewers: epriestley

Reviewed By: epriestley

Subscribers: Korvin

Differential Revision: https://secure.phabricator.com/D15406
This commit is contained in:
Chad Little 2016-03-05 12:28:56 -08:00
parent 010b7811b4
commit 090252a89e
1 changed files with 7 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
src/applications/macro/controller/PhabricatorMacroViewController.php
View file

@ -40,7 +40,8 @@ final class PhabricatorMacroViewController
$header = id(new PHUIHeaderView()) $header = id(new PHUIHeaderView())
->setUser($viewer) ->setUser($viewer)
->setPolicyObject($macro) ->setPolicyObject($macro)
->setHeader($title_long); ->setHeader($macro->getName())
->setHeaderIcon('fa-file-image-o');
if (!$macro->getIsDisabled()) { if (!$macro->getIsDisabled()) {
$header->setStatus('fa-check', 'bluegrey', pht('Active')); $header->setStatus('fa-check', 'bluegrey', pht('Active'));
@ -177,9 +178,13 @@ final class PhabricatorMacroViewController
$viewer->renderHandle($audio_phid)); $viewer->renderHandle($audio_phid));
} }
if ($view->hasAnyProperties()) {
return $view; return $view;
} }
return null;
}
private function buildFileView( private function buildFileView(
PhabricatorFileImageMacro $macro) { PhabricatorFileImageMacro $macro) {
$viewer = $this->getViewer(); $viewer = $this->getViewer();