mirror of
https://we.phorge.it/source/phorge.git
synced 2024-11-27 01:02:42 +01:00
Link to "large" view from inline comment for previous revision
Summary: Also link to `D1?id=` instead of `?id=` because some IE versions linked to root in this case. Test Plan: Click on old diff's inline comment link on large revision. Reviewers: epriestley Reviewed By: epriestley CC: aran, Koolvin Differential Revision: https://secure.phabricator.com/D2260
This commit is contained in:
parent
752d742085
commit
091248ebe6
1 changed files with 5 additions and 1 deletions
|
@ -291,7 +291,11 @@ final class DifferentialRevisionCommentView extends AphrontView {
|
|||
if (!$is_visible) {
|
||||
$diff_id = $changeset->getDiffID();
|
||||
$item['where'] = '(On Diff #'.$diff_id.')';
|
||||
$item['href'] = '?id='.$diff_id.'#inline-'.$inline->getID();
|
||||
$item['href'] =
|
||||
'D'.$this->comment->getRevisionID().
|
||||
'?id='.$diff_id.
|
||||
'&large=true'.
|
||||
'#inline-'.$inline->getID();
|
||||
}
|
||||
|
||||
$items[] = $item;
|
||||
|
|
Loading…
Reference in a new issue