revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-30 02:32:42 +01:00
Code Issues Releases Wiki Activity

Link to "large" view from inline comment for previous revision

Browse source 
Summary: Also link to `D1?id=` instead of `?id=` because some IE versions linked to root in this case.

Test Plan: Click on old diff's inline comment link on large revision.

Reviewers: epriestley

Reviewed By: epriestley

CC: aran, Koolvin

Differential Revision: https://secure.phabricator.com/D2260
This commit is contained in:
vrana 2012-04-17 16:35:45 -07:00
parent 752d742085
commit 091248ebe6
1 changed files with 5 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
src/applications/differential/view/revisioncomment/DifferentialRevisionCommentView.php
View file

@ -291,7 +291,11 @@ final class DifferentialRevisionCommentView extends AphrontView {
if (!$is_visible) { if (!$is_visible) {
$diff_id = $changeset->getDiffID(); $diff_id = $changeset->getDiffID();
$item['where'] = '(On Diff #'.$diff_id.')'; $item['where'] = '(On Diff #'.$diff_id.')';
$item['href'] = '?id='.$diff_id.'#inline-'.$inline->getID(); $item['href'] =
'D'.$this->comment->getRevisionID().
'?id='.$diff_id.
'&large=true'.
'#inline-'.$inline->getID();
} }
$items[] = $item; $items[] = $item;