From 094026f64a49a6a3b569fb1154ec65221f7909be Mon Sep 17 00:00:00 2001 From: Chad Little Date: Thu, 8 May 2014 17:41:48 -0700 Subject: [PATCH] Add overflow: hidden back to obj-list Summary: Long titles tend to break some of the layout. I removed this fixing another bug, but ultimately we changed directions on boards and it doesn't repro anymore. Test Plan: Test workboards with tasks on and off the screen. All are drawn. Test the homepage with lots of overflowing information. Make sure objects don't break the 'card'. Reviewers: btrahan, epriestley Reviewed By: epriestley Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9020 --- resources/celerity/map.php | 14 +++++++------- .../rsrc/css/phui/phui-object-item-list-view.css | 2 ++ 2 files changed, 9 insertions(+), 7 deletions(-) diff --git a/resources/celerity/map.php b/resources/celerity/map.php index 767ea18d93..a58e434861 100644 --- a/resources/celerity/map.php +++ b/resources/celerity/map.php @@ -7,7 +7,7 @@ return array( 'names' => array( - 'core.pkg.css' => '719389b0', + 'core.pkg.css' => 'c00e58c8', 'core.pkg.js' => 'b2ed04a2', 'darkconsole.pkg.js' => 'ca8671ce', 'differential.pkg.css' => '4b8686e3', @@ -137,7 +137,7 @@ return array( 'rsrc/css/phui/phui-info-panel.css' => '27ea50a1', 'rsrc/css/phui/phui-list.css' => 'ef8035b6', 'rsrc/css/phui/phui-object-box.css' => 'ce92d8ec', - 'rsrc/css/phui/phui-object-item-list-view.css' => '3bf8e1c9', + 'rsrc/css/phui/phui-object-item-list-view.css' => '7cf6ccf9', 'rsrc/css/phui/phui-pinboard-view.css' => 'e7d3b05e', 'rsrc/css/phui/phui-property-list-view.css' => 'af4b381f', 'rsrc/css/phui/phui-remarkup-preview.css' => '19ad512b', @@ -157,7 +157,7 @@ return array( 'rsrc/css/sprite-docs.css' => '5f65d0da', 'rsrc/css/sprite-gradient.css' => 'a10def53', 'rsrc/css/sprite-icons.css' => 'f19a828c', - 'rsrc/css/sprite-login.css' => '9fbaec81', + 'rsrc/css/sprite-login.css' => '8d10fb28', 'rsrc/css/sprite-main-header.css' => '92720ee2', 'rsrc/css/sprite-menu.css' => '8da53882', 'rsrc/css/sprite-minicons.css' => 'df4f76fe', @@ -325,8 +325,8 @@ return array( 'rsrc/image/sprite-gradient.png' => '4ece0b62', 'rsrc/image/sprite-icons-X2.png' => '0d5867c0', 'rsrc/image/sprite-icons.png' => '3f754bda', - 'rsrc/image/sprite-login-X2.png' => '81c1344f', - 'rsrc/image/sprite-login.png' => '7c729508', + 'rsrc/image/sprite-login-X2.png' => 'bf5ceccc', + 'rsrc/image/sprite-login.png' => 'c1e200b3', 'rsrc/image/sprite-main-header.png' => '83521873', 'rsrc/image/sprite-menu-X2.png' => '949974c6', 'rsrc/image/sprite-menu.png' => '307d5da0', @@ -766,7 +766,7 @@ return array( 'phui-info-panel-css' => '27ea50a1', 'phui-list-view-css' => 'ef8035b6', 'phui-object-box-css' => 'ce92d8ec', - 'phui-object-item-list-view-css' => '3bf8e1c9', + 'phui-object-item-list-view-css' => '7cf6ccf9', 'phui-pinboard-view-css' => 'e7d3b05e', 'phui-property-list-view-css' => 'af4b381f', 'phui-remarkup-preview-css' => '19ad512b', @@ -804,7 +804,7 @@ return array( 'sprite-docs-css' => '5f65d0da', 'sprite-gradient-css' => 'a10def53', 'sprite-icons-css' => 'f19a828c', - 'sprite-login-css' => '9fbaec81', + 'sprite-login-css' => '8d10fb28', 'sprite-main-header-css' => '92720ee2', 'sprite-menu-css' => '8da53882', 'sprite-minicons-css' => 'df4f76fe', diff --git a/webroot/rsrc/css/phui/phui-object-item-list-view.css b/webroot/rsrc/css/phui/phui-object-item-list-view.css index 04f89e7503..634b5f9c17 100644 --- a/webroot/rsrc/css/phui/phui-object-item-list-view.css +++ b/webroot/rsrc/css/phui/phui-object-item-list-view.css @@ -39,6 +39,7 @@ border-color: {$lightgreyborder}; border-width: 0 0 0 4px; margin: 5px 0; + overflow: hidden; } .phui-object-item .phui-icon-view { @@ -52,6 +53,7 @@ border-width: 1px 1px 1px 0; position: relative; min-height: 29px; + overflow: hidden; } .phui-object-list-cards .phui-object-item-frame {