revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-22 14:52:41 +01:00
Code Issues Releases Wiki Activity

Fix "add more metadata" fatal in Pholio

Browse source 
Summary: Ref T13332. This fix isn't terribly satisfying, but resolves the issue: this behavior may attempt to build HTML blocks with metadata after Javascript footer rendering has started. Use `hsprintf()` to flatten the markup earlier.

Test Plan: Put a `T123` reference in the description of a Pholio image, then loaded a mock.

Reviewers: amckinley

Reviewed By: amckinley

Maniphest Tasks: T13332

Differential Revision: https://secure.phabricator.com/D20647
This commit is contained in:
epriestley 2019-07-11 14:37:33 -07:00
parent 2c435433e0
commit 099919366b
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/applications/pholio/view/PholioMockImagesView.php
View file

@ -103,7 +103,7 @@ final class PholioMockImagesView extends AphrontView {
'width' => $x, 'width' => $x,
'height' => $y, 'height' => $y,
'title' => $image->getName(), 'title' => $image->getName(),
'descriptionMarkup' => $description, 'descriptionMarkup' => hsprintf('%s', $description),
'isObsolete' => (bool)$image->getIsObsolete(), 'isObsolete' => (bool)$image->getIsObsolete(),
'isImage' => $file->isViewableImage(), 'isImage' => $file->isViewableImage(),
'isViewable' => $file->isViewableInBrowser(), 'isViewable' => $file->isViewableInBrowser(),