From 09c12280ef584d227bf4007ab889248522e079b4 Mon Sep 17 00:00:00 2001 From: Chad Little Date: Sat, 23 May 2015 11:01:29 -0700 Subject: [PATCH] [Redesign] Better icon spacing for PHUIObjectListItem Summary: Ref T8099, Improve hit area for new icon, tweaks grippable spacing and app icon spacing. Also Tablet layout updates Test Plan: Test Maniphest home, Pinning apps, Dashboards Reviewers: btrahan, epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Maniphest Tasks: T8099 Differential Revision: https://secure.phabricator.com/D12986 --- resources/celerity/map.php | 18 +++++++++--------- webroot/rsrc/css/phui/phui-info-view.css | 2 +- webroot/rsrc/css/phui/phui-object-box.css | 4 ++++ .../css/phui/phui-object-item-list-view.css | 10 +++++----- webroot/rsrc/css/phui/phui-timeline-view.css | 6 +++++- 5 files changed, 24 insertions(+), 16 deletions(-) diff --git a/resources/celerity/map.php b/resources/celerity/map.php index 78a5ae92b2..a38f56fa87 100644 --- a/resources/celerity/map.php +++ b/resources/celerity/map.php @@ -7,7 +7,7 @@ */ return array( 'names' => array( - 'core.pkg.css' => '979f9a16', + 'core.pkg.css' => '341abbd5', 'core.pkg.js' => '9db3e620', 'darkconsole.pkg.js' => 'e7393ebb', 'differential.pkg.css' => 'bb338e4b', @@ -138,10 +138,10 @@ return array( 'rsrc/css/phui/phui-icon.css' => '88ba9081', 'rsrc/css/phui/phui-image-mask.css' => '5a8b09c8', 'rsrc/css/phui/phui-info-panel.css' => '27ea50a1', - 'rsrc/css/phui/phui-info-view.css' => '33595731', + 'rsrc/css/phui/phui-info-view.css' => '33e54618', 'rsrc/css/phui/phui-list.css' => 'e448b6ba', - 'rsrc/css/phui/phui-object-box.css' => 'b9d566e3', - 'rsrc/css/phui/phui-object-item-list-view.css' => '2032bf8b', + 'rsrc/css/phui/phui-object-box.css' => 'e3441f90', + 'rsrc/css/phui/phui-object-item-list-view.css' => '8538712d', 'rsrc/css/phui/phui-pinboard-view.css' => '22891c15', 'rsrc/css/phui/phui-property-list-view.css' => 'd2d143ea', 'rsrc/css/phui/phui-remarkup-preview.css' => '19ad512b', @@ -149,7 +149,7 @@ return array( 'rsrc/css/phui/phui-status.css' => '888cedb8', 'rsrc/css/phui/phui-tag-view.css' => '402691cc', 'rsrc/css/phui/phui-text.css' => 'cf019f54', - 'rsrc/css/phui/phui-timeline-view.css' => 'a85542c8', + 'rsrc/css/phui/phui-timeline-view.css' => '8eaab66c', 'rsrc/css/phui/phui-workboard-view.css' => 'd39ec91e', 'rsrc/css/phui/phui-workpanel-view.css' => '015a0cab', 'rsrc/css/sprite-login.css' => 'a3526809', @@ -773,11 +773,11 @@ return array( 'phui-icon-view-css' => '88ba9081', 'phui-image-mask-css' => '5a8b09c8', 'phui-info-panel-css' => '27ea50a1', - 'phui-info-view-css' => '33595731', + 'phui-info-view-css' => '33e54618', 'phui-inline-comment-view-css' => '2174771a', 'phui-list-view-css' => 'e448b6ba', - 'phui-object-box-css' => 'b9d566e3', - 'phui-object-item-list-view-css' => '2032bf8b', + 'phui-object-box-css' => 'e3441f90', + 'phui-object-item-list-view-css' => '8538712d', 'phui-pinboard-view-css' => '22891c15', 'phui-property-list-view-css' => 'd2d143ea', 'phui-remarkup-preview-css' => '19ad512b', @@ -785,7 +785,7 @@ return array( 'phui-status-list-view-css' => '888cedb8', 'phui-tag-view-css' => '402691cc', 'phui-text-css' => 'cf019f54', - 'phui-timeline-view-css' => 'a85542c8', + 'phui-timeline-view-css' => '8eaab66c', 'phui-workboard-view-css' => 'd39ec91e', 'phui-workpanel-view-css' => '015a0cab', 'phuix-action-list-view' => 'b5c256b8', diff --git a/webroot/rsrc/css/phui/phui-info-view.css b/webroot/rsrc/css/phui/phui-info-view.css index 4e00fdf528..0a7f5179e4 100644 --- a/webroot/rsrc/css/phui/phui-info-view.css +++ b/webroot/rsrc/css/phui/phui-info-view.css @@ -10,7 +10,7 @@ border-radius: 3px; } -.device-phone .phui-info-view { +.device .phui-info-view { margin: 8px; } diff --git a/webroot/rsrc/css/phui/phui-object-box.css b/webroot/rsrc/css/phui/phui-object-box.css index b2542ae353..8b5ebb80c8 100644 --- a/webroot/rsrc/css/phui/phui-object-box.css +++ b/webroot/rsrc/css/phui/phui-object-box.css @@ -48,6 +48,10 @@ div.phui-object-box.phui-object-box-flush { padding-bottom: 8px; } +.device-tablet .phui-object-box { + margin: 8px 8px 0 8px; +} + /* - Object Box Colors ------------------------------------------------------ */ .phui-box-border.phui-object-box-green { diff --git a/webroot/rsrc/css/phui/phui-object-item-list-view.css b/webroot/rsrc/css/phui/phui-object-item-list-view.css index 121be765dc..4b28b91df1 100644 --- a/webroot/rsrc/css/phui/phui-object-item-list-view.css +++ b/webroot/rsrc/css/phui/phui-object-item-list-view.css @@ -68,7 +68,7 @@ ul.phui-object-item-list-view { .phui-object-item-status-icon { font-weight: bold; - padding: 0 8px; + padding: 3px; font-size: 16px; } @@ -115,7 +115,7 @@ ul.phui-object-item-list-view { top: 0; bottom: 0; left: 0; - width: 17px; + width: 16px; background: url('/rsrc/image/texture/grip.png') center center no-repeat; } @@ -124,7 +124,7 @@ ul.phui-object-item-list-view { } .phui-object-item-grippable .phui-object-item-frame { - padding-left: 11px; + padding-left: 16px; } .device .phui-object-item-grippable .phui-object-item-frame { @@ -147,7 +147,7 @@ ul.phui-object-item-list-view { } .phui-object-item-col0 { - width: 24px; + width: 20px; display: table-cell; vertical-align: middle; } @@ -673,7 +673,7 @@ ul.phui-object-item-list-view .phui-object-item-selected .phui-object-item-image-icon { width: 30px; height: 30px; - margin: 4px; + margin: 4px 0; position: absolute; } diff --git a/webroot/rsrc/css/phui/phui-timeline-view.css b/webroot/rsrc/css/phui/phui-timeline-view.css index d35a5458ee..95bcbe1ab2 100644 --- a/webroot/rsrc/css/phui/phui-timeline-view.css +++ b/webroot/rsrc/css/phui/phui-timeline-view.css @@ -9,8 +9,12 @@ background-position: 94px; } +.device .phui-timeline-view { + padding: 0 8px; +} + .device-tablet .phui-timeline-view { - background-position: 31px; + background-position: 24px; } .device-phone .phui-timeline-view {