revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-18 19:40:55 +01:00
Code Issues Releases Wiki Activity

Allow herald rules to be deleted with ./bin/remove destroy.

Browse source 
Summary: Fixes T5286. Allow herald rules to be deleted using the `./bin/remove destroy` workflow.

Test Plan: Created a herald rule. Deleted it with `./bin/remove destroy`.

Reviewers: epriestley, #blessed_reviewers

Reviewed By: epriestley, #blessed_reviewers

Subscribers: epriestley, Korvin

Maniphest Tasks: T5286

Differential Revision: https://secure.phabricator.com/D9416
This commit is contained in:
Joshua Spence 2014-06-07 11:19:04 -07:00 committed by epriestley
parent d06679a021
commit 0a534d1d1f
1 changed files with 13 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
src/applications/herald/storage/HeraldRule.php
View file

@ -3,7 +3,8 @@
final class HeraldRule extends HeraldDAO final class HeraldRule extends HeraldDAO
implements implements
PhabricatorFlaggableInterface, PhabricatorFlaggableInterface,
PhabricatorPolicyInterface { PhabricatorPolicyInterface,
PhabricatorDestructableInterface {
const TABLE_RULE_APPLIED = 'herald_ruleapplied'; const TABLE_RULE_APPLIED = 'herald_ruleapplied';
@ -250,4 +251,15 @@ final class HeraldRule extends HeraldDAO
return null; return null;
} }
/* -( PhabricatorDestructableInterface )----------------------------------- */
public function destroyObjectPermanently(
PhabricatorDestructionEngine $engine) {
$this->openTransaction();
$this->delete();
$this->saveTransaction();
}
} }