1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-10 08:52:39 +01:00

Purge readthrough caches before applying schema adjustments

Summary: Ref T1191. The bulk of the slowness in T1191 is copying tables. In some cases, we can't avoid this, but we have various readthrough caches which may be very large and are safe to drop, and dropping them is very quick (much less than 1 second). In particular, dropping the `changeset_parse_cache` made the process at least ~8 minutes faster on `secure.phabricator.com` (I killed it after 8 minutes, so I'm not sure what the real number is).

Test Plan: Ran `bin/storage adjust` and saw it drop caches before applying adjustments.

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: epriestley

Maniphest Tasks: T1191

Differential Revision: https://secure.phabricator.com/D10616
This commit is contained in:
epriestley 2014-10-01 12:44:42 -07:00
parent 3a644cf6cc
commit 0a6473138f

View file

@ -123,6 +123,14 @@ final class PhabricatorStorageManagementAdjustWorkflow
}
}
$console->writeOut(
"%s\n",
pht('Dropping caches, for faster migrations...'));
$root = dirname(phutil_get_library_root('phabricator'));
$bin = $root.'/bin/cache';
phutil_passthru('%s purge --purge-all', $bin);
$console->writeOut(
"%s\n",
pht('Fixing schema issues...'));