revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-19 13:22:42 +01:00
Code Issues Releases Wiki Activity

Use authoritative PHIDs for Herald "Task Projects" condition

Browse source 
Summary:
Fixes T5707. After work on T5245, the `$task` object may not have the correct set of task PHIDs attached to it when Herald is invoked.

Instead, just fetch the authoritative set. This is simple, and Herald is not super performance sensitive (happens on a write) so hitting the DB once is fine.

Test Plan: Created a task with projects, verified the projects field contained the correct values when processed by Herald.

Reviewers: chad, btrahan, joshuaspence

Reviewed By: joshuaspence

Subscribers: epriestley

Maniphest Tasks: T5707

Differential Revision: https://secure.phabricator.com/D10060
This commit is contained in:
epriestley 2014-07-26 09:48:01 -07:00
parent c75e12038c
commit 0b5fcb36ae
1 changed files with 3 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/applications/herald/adapter/HeraldManiphestTaskAdapter.php
View file

@ -140,7 +140,9 @@ final class HeraldManiphestTaskAdapter extends HeraldAdapter {
case self::FIELD_CC: case self::FIELD_CC:
return $this->getTask()->getCCPHIDs(); return $this->getTask()->getCCPHIDs();
case self::FIELD_PROJECTS: case self::FIELD_PROJECTS:
return $this->getTask()->getProjectPHIDs(); return PhabricatorEdgeQuery::loadDestinationPHIDs(
$this->getTask()->getPHID(),
PhabricatorProjectObjectHasProjectEdgeType::EDGECONST);
case self::FIELD_TASK_PRIORITY: case self::FIELD_TASK_PRIORITY:
return $this->getTask()->getPriority(); return $this->getTask()->getPriority();
} }