revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-24 22:40:55 +01:00
Code Issues Releases Wiki Activity

Work around an issue with custom "users" fields in Maniphest

Browse source 
Summary:
Fixes T9558. The recent changes to validate PHID fields don't work cleanly with this gross hack.

This can probably be unwound now but it will definitely get fixed in T9132 so I may just wait for that.

Test Plan: Edited a custom "users" field in Maniphest. This should only affect Maniphest because it has a weird hack.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T9558

Differential Revision: https://secure.phabricator.com/D14264
This commit is contained in:
epriestley 2015-10-13 08:41:49 -07:00
parent 3f3626c11a
commit 0b6c031042
1 changed files with 2 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
src/applications/maniphest/controller/ManiphestTaskEditController.php
View file

@ -198,7 +198,8 @@ final class ManiphestTaskEditController extends ManiphestController {
// in a meaningful way. For now, build User objects. Once the Maniphest // in a meaningful way. For now, build User objects. Once the Maniphest
// objects exist, this will switch over automatically. This is a big // objects exist, this will switch over automatically. This is a big
// hack but shouldn't be long for this world. // hack but shouldn't be long for this world.
$placeholder_editor = new PhabricatorUserProfileEditor(); $placeholder_editor = id(new PhabricatorUserProfileEditor())
->setActor($viewer);
$field_errors = $aux_field->validateApplicationTransactions( $field_errors = $aux_field->validateApplicationTransactions(
$placeholder_editor, $placeholder_editor,