mirror of
https://we.phorge.it/source/phorge.git
synced 2024-11-22 06:42:42 +01:00
Fix PHP 8.1 "strlen(null)" exception for "/bin/files migrate" without parameter
Summary: `strlen()` was used in Phabricator to check if a generic value is a non-empty string. This behavior is deprecated since PHP 8.1. Phorge adopts `phutil_nonempty_string()` as a replacement. Note: this may highlight other absurd input values that might be worth correcting instead of just ignoring. If phutil_nonempty_string() throws an exception in your instance, report it to Phorge to evaluate and fix that specific corner case. ``` ERROR 8192: strlen(): Passing null to parameter #1 ($string) of type string is deprecated at [/var/www/html/phorge/phorge/src/applications/files/management/PhabricatorFilesManagementMigrateWorkflow.php:65] ``` Test Plan: Run `../phorge/bin/files migrate`: Get no `strlen()` error anymore but only expected output `Usage Exception: Specify an engine to migrate to with `--engine`. Use `files engines` to get a list of engines.` Reviewers: O1 Blessed Committers, valerio.bozzolan Reviewed By: O1 Blessed Committers, valerio.bozzolan Subscribers: tobiaswiese, valerio.bozzolan, Matthew, Cigaryno Differential Revision: https://we.phorge.it/D25594
This commit is contained in:
parent
c59a883e9d
commit
0bdfcc47e7
1 changed files with 1 additions and 1 deletions
|
@ -62,7 +62,7 @@ final class PhabricatorFilesManagementMigrateWorkflow
|
|||
// it as though it is configured to use the specified location.
|
||||
|
||||
$local_disk_source = $args->getArg('local-disk-source');
|
||||
if (strlen($local_disk_source)) {
|
||||
if (phutil_nonempty_string($local_disk_source)) {
|
||||
$path = Filesystem::resolvePath($local_disk_source);
|
||||
try {
|
||||
Filesystem::assertIsDirectory($path);
|
||||
|
|
Loading…
Reference in a new issue