From 0c6e03d5aff9bafa55c81c1a9645461cf07aec86 Mon Sep 17 00:00:00 2001
From: epriestley <git@epriestley.com>
Date: Tue, 13 Dec 2016 17:45:34 -0800
Subject: [PATCH] Fix a ModularTransactions exception with custom fields that
 support change details

Summary: We're throwing here when we actually want to return `null` so we make it into custom field handling code. See Conpherence.

Test Plan: Found a failing task and re-executed it with `bin/worker execute --id <id>`; after this change, it didn't fatal.

Reviewers: chad

Reviewed By: chad

Differential Revision: https://secure.phabricator.com/D17051
---
 .../transactions/storage/PhabricatorModularTransactionType.php  | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/applications/transactions/storage/PhabricatorModularTransactionType.php b/src/applications/transactions/storage/PhabricatorModularTransactionType.php
index 21cee01cda..2ae06131f4 100644
--- a/src/applications/transactions/storage/PhabricatorModularTransactionType.php
+++ b/src/applications/transactions/storage/PhabricatorModularTransactionType.php
@@ -68,7 +68,7 @@ abstract class PhabricatorModularTransactionType
   }
 
   public function newChangeDetailView() {
-    throw new PhutilMethodNotImplementedException();
+    return null;
   }
 
   public function getMailDiffSectionHeader() {