Implement the getName method in PhabricatorApplication subclasses

Summary: Provide an implementation for the `getName` method rather than automagically determining the application name.

Test Plan: Saw reasonable application names in the launcher.

Reviewers: #blessed_reviewers, epriestley

Reviewed By: #blessed_reviewers, epriestley

Subscribers: epriestley, Korvin

Differential Revision: https://secure.phabricator.com/D10027

src/applications/audit/application/PhabricatorAuditApplication.php

@@ -10,6 +10,10 @@ final class PhabricatorAuditApplication extends PhabricatorApplication {
     return 'audit';
   }
 
+  public function getName() {
+    return pht('Audit');
+  }
+
   public function getShortDescription() {
     return pht('Browse and Audit Commits');
   }

src/applications/auth/application/PhabricatorAuthApplication.php

@@ -18,6 +18,10 @@ final class PhabricatorAuthApplication extends PhabricatorApplication {
     return $viewer->getIsAdmin();
   }
 
+  public function getName() {
+    return pht('Auth');
+  }
+
   public function getShortDescription() {
     return pht('Login/Registration');
   }

src/applications/base/PhabricatorApplication.php

@@ -27,23 +27,21 @@ abstract class PhabricatorApplication implements PhabricatorPolicyInterface {
 /* -(  Application Information  )-------------------------------------------- */
 
 
+  /**
+   * TODO: This should be abstract, but is not for historical reasons.
+   */
   public function getName() {
-
-    // TODO: This is sort of gross.
+    phutil_deprecated(
+      'Automatic naming of `PhabricatorApplication` classes.',
+      'You should override the `getName` method.');
 
     $match = null;
-
-    $regex = '/^Phabricator([A-Z][a-zA-Z]*)Application$/';
-    if (preg_match($regex, get_class($this), $match)) {
-      return $match[1];
-    }
-
     $regex = '/^PhabricatorApplication([A-Z][a-zA-Z]*)$/';
     if (preg_match($regex, get_class($this), $match)) {
       return $match[1];
     }
 
-    throw new Exception('Unable to determine application name automagically.');
+    throw new PhutilMethodNotImplementedException();
   }
 
   public function getShortDescription() {

src/applications/base/controller/__tests__/PhabricatorTestApplication.php

@@ -4,6 +4,10 @@ final class PhabricatorTestApplication extends PhabricatorApplication {
 
   private $policies = array();
 
+  public function getName() {
+    return pht('Test');
+  }
+
   public function isUnlisted() {
     return true;
   }

src/applications/calendar/application/PhabricatorCalendarApplication.php

@@ -2,6 +2,10 @@
 
 final class PhabricatorCalendarApplication extends PhabricatorApplication {
 
+  public function getName() {
+    return pht('Calendar');
+  }
+
   public function getShortDescription() {
     return pht('Upcoming Events');
   }

src/applications/chatlog/application/PhabricatorChatLogApplication.php

@@ -6,6 +6,10 @@ final class PhabricatorChatLogApplication extends PhabricatorApplication {
     return '/chatlog/';
   }
 
+  public function getName() {
+    return pht('ChatLog');
+  }
+
   public function getShortDescription() {
     return pht('IRC Logs');
   }

src/applications/conduit/application/PhabricatorConduitApplication.php

@@ -18,6 +18,10 @@ final class PhabricatorConduitApplication extends PhabricatorApplication {
     return PhabricatorEnv::getDoclink('Conduit Technical Documentation');
   }
 
+  public function getName() {
+    return pht('Conduit');
+  }
+
   public function getShortDescription() {
     return pht('Developer API');
   }

src/applications/config/application/PhabricatorConfigApplication.php

@@ -26,6 +26,10 @@ final class PhabricatorConfigApplication extends PhabricatorApplication {
     return false;
   }
 
+  public function getName() {
+    return 'Config';
+  }
+
   public function getShortDescription() {
     return pht('Configure Phabricator');
   }

src/applications/conpherence/application/PhabricatorConpherenceApplication.php

@@ -6,6 +6,10 @@ final class PhabricatorConpherenceApplication extends PhabricatorApplication {
     return '/conpherence/';
   }
 
+  public function getName() {
+    return pht('Conpherence');
+  }
+
   public function getShortDescription() {
     return pht('Send Messages');
   }

src/applications/countdown/application/PhabricatorCountdownApplication.php

@@ -10,6 +10,10 @@ final class PhabricatorCountdownApplication extends PhabricatorApplication {
     return 'countdown';
   }
 
+  public function getName() {
+    return pht('Countdown');
+  }
+
   public function getShortDescription() {
     return pht('Countdown to Events');
   }

src/applications/differential/application/PhabricatorDifferentialApplication.php

@@ -6,6 +6,10 @@ final class PhabricatorDifferentialApplication extends PhabricatorApplication {
     return '/differential/';
   }
 
+  public function getName() {
+    return pht('Differential');
+  }
+
   public function getShortDescription() {
     return pht('Review Code');
   }

src/applications/diffusion/application/PhabricatorDiffusionApplication.php

@@ -2,6 +2,10 @@
 
 final class PhabricatorDiffusionApplication extends PhabricatorApplication {
 
+  public function getName() {
+    return pht('Diffusion');
+  }
+
   public function getShortDescription() {
     return pht('Host and Browse Repositories');
   }

src/applications/diviner/application/PhabricatorDivinerApplication.php

@@ -10,6 +10,10 @@ final class PhabricatorDivinerApplication extends PhabricatorApplication {
     return 'diviner';
   }
 
+  public function getName() {
+    return pht('Diviner');
+  }
+
   public function getShortDescription() {
     return pht('Documentation');
   }

src/applications/doorkeeper/application/PhabricatorDoorkeeperApplication.php

@@ -10,6 +10,10 @@ final class PhabricatorDoorkeeperApplication extends PhabricatorApplication {
     return false;
   }
 
+  public function getName() {
+    return pht('Doorkeeper');
+  }
+
   public function getShortDescription() {
     return pht('Connect to Other Software');
   }

src/applications/drydock/application/PhabricatorDrydockApplication.php

@@ -6,6 +6,10 @@ final class PhabricatorDrydockApplication extends PhabricatorApplication {
     return '/drydock/';
   }
 
+  public function getName() {
+    return pht('Drydock');
+  }
+
   public function getShortDescription() {
     return pht('Allocate Software Resources');
   }

src/applications/feed/application/PhabricatorFeedApplication.php

@@ -6,6 +6,10 @@ final class PhabricatorFeedApplication extends PhabricatorApplication {
     return '/feed/';
   }
 
+  public function getName() {
+    return pht('Feed');
+  }
+
   public function getShortDescription() {
     return pht('Review Recent Activity');
   }

src/applications/files/application/PhabricatorFilesApplication.php

@@ -6,6 +6,10 @@ final class PhabricatorFilesApplication extends PhabricatorApplication {
     return '/file/';
   }
 
+  public function getName() {
+    return pht('Files');
+  }
+
   public function getShortDescription() {
     return 'Store and Share Files';
   }

src/applications/flag/application/PhabricatorFlagsApplication.php

@@ -2,6 +2,10 @@
 
 final class PhabricatorFlagsApplication extends PhabricatorApplication {
 
+  public function getName() {
+    return pht('Flags');
+  }
+
   public function getShortDescription() {
     return pht('Personal Bookmarks');
   }

src/applications/harbormaster/application/PhabricatorHarbormasterApplication.php

@@ -6,6 +6,10 @@ final class PhabricatorHarbormasterApplication extends PhabricatorApplication {
     return '/harbormaster/';
   }
 
+  public function getName() {
+    return pht('Harbormaster');
+  }
+
   public function getShortDescription() {
     return pht('Build/CI');
   }

src/applications/help/application/PhabricatorHelpApplication.php

@@ -2,6 +2,10 @@
 
 final class PhabricatorHelpApplication extends PhabricatorApplication {
 
+  public function getName() {
+    return pht('Help');
+  }
+
   public function canUninstall() {
     return false;
   }

src/applications/herald/application/PhabricatorHeraldApplication.php

@@ -10,6 +10,10 @@ final class PhabricatorHeraldApplication extends PhabricatorApplication {
     return 'herald';
   }
 
+  public function getName() {
+    return pht('Herald');
+  }
+
   public function getShortDescription() {
     return pht('Create Notification Rules');
   }

src/applications/home/application/PhabricatorHomeApplication.php

@@ -8,6 +8,10 @@ final class PhabricatorHomeApplication extends PhabricatorApplication {
     return '/home/';
   }
 
+  public function getName() {
+    return pht('Home');
+  }
+
   public function getShortDescription() {
     return pht('Command Center');
   }

src/applications/legalpad/application/PhabricatorLegalpadApplication.php

@@ -6,6 +6,10 @@ final class PhabricatorLegalpadApplication extends PhabricatorApplication {
     return '/legalpad/';
   }
 
+  public function getName() {
+    return pht('Legalpad');
+  }
+
   public function getShortDescription() {
     return pht('Agreements and Signatures');
   }

src/applications/macro/application/PhabricatorMacroApplication.php

@@ -6,6 +6,10 @@ final class PhabricatorMacroApplication extends PhabricatorApplication {
     return '/macro/';
   }
 
+  public function getName() {
+    return pht('Macro');
+  }
+
   public function getShortDescription() {
     return pht('Image Macros and Memes');
   }

src/applications/maniphest/application/PhabricatorManiphestApplication.php

@@ -2,8 +2,12 @@
 
 final class PhabricatorManiphestApplication extends PhabricatorApplication {
 
+  public function getName() {
+    return pht('Maniphest');
+  }
+
   public function getShortDescription() {
-    return 'Tasks and Bugs';
+    return pht('Tasks and Bugs');
   }
 
   public function getBaseURI() {

src/applications/meta/application/PhabricatorApplicationsApplication.php

@@ -2,6 +2,10 @@
 
 final class PhabricatorApplicationsApplication extends PhabricatorApplication {
 
+  public function getName() {
+    return pht('Applications');
+  }
+
   public function canUninstall() {
     return false;
   }

src/applications/people/application/PhabricatorPeopleApplication.php

@@ -2,6 +2,10 @@
 
 final class PhabricatorPeopleApplication extends PhabricatorApplication {
 
+  public function getName() {
+    return pht('People');
+  }
+
   public function getShortDescription() {
     return pht('User Accounts and Profiles');
   }

src/applications/phrequent/application/PhabricatorPhrequentApplication.php

@@ -2,6 +2,10 @@
 
 final class PhabricatorPhrequentApplication extends PhabricatorApplication {
 
+  public function getName() {
+    return pht('Phrequent');
+  }
+
   public function getShortDescription() {
     return pht('Track Time Spent');
   }

src/applications/phriction/application/PhabricatorPhrictionApplication.php

@@ -2,6 +2,10 @@
 
 final class PhabricatorPhrictionApplication extends PhabricatorApplication {
 
+  public function getName() {
+    return pht('Phriction');
+  }
+
   public function getShortDescription() {
     return pht('Wiki');
   }

src/applications/policy/application/PhabricatorPolicyApplication.php

@@ -2,6 +2,10 @@
 
 final class PhabricatorPolicyApplication extends PhabricatorApplication {
 
+  public function getName() {
+    return pht('Policy');
+  }
+
   public function isLaunchable() {
     return false;
   }

src/applications/ponder/application/PhabricatorPonderApplication.php

@@ -6,6 +6,10 @@ final class PhabricatorPonderApplication extends PhabricatorApplication {
     return '/ponder/';
   }
 
+  public function getName() {
+    return pht('Ponder');
+  }
+
   public function getShortDescription() {
     return pht('Questions and Answers');
   }

src/applications/repository/application/PhabricatorRepositoriesApplication.php

@@ -10,6 +10,10 @@ final class PhabricatorRepositoriesApplication extends PhabricatorApplication {
     return 'repositories';
   }
 
+  public function getName() {
+    return pht('Repositories');
+  }
+
   public function getShortDescription() {
     return pht('(Deprecated)');
   }

src/applications/settings/application/PhabricatorSettingsApplication.php

@@ -6,6 +6,10 @@ final class PhabricatorSettingsApplication extends PhabricatorApplication {
     return '/settings/';
   }
 
+  public function getName() {
+    return pht('Settings');
+  }
+
   public function getShortDescription() {
     return pht('User Preferences');
   }

src/applications/slowvote/application/PhabricatorSlowvoteApplication.php

@@ -10,8 +10,12 @@ final class PhabricatorSlowvoteApplication extends PhabricatorApplication {
     return 'slowvote';
   }
 
+  public function getName() {
+    return pht('Slowvote');
+  }
+
   public function getShortDescription() {
-    return 'Conduct Polls';
+    return pht('Conduct Polls');
   }
 
   public function getTitleGlyph() {

src/applications/subscriptions/application/PhabricatorSubscriptionsApplication.php

@@ -2,6 +2,10 @@
 
 final class PhabricatorSubscriptionsApplication extends PhabricatorApplication {
 
+  public function getName() {
+    return pht('Subscriptions');
+  }
+
   public function isLaunchable() {
     return false;
   }

src/applications/support/application/PhabricatorSupportApplication.php

@@ -2,6 +2,10 @@
 
 final class PhabricatorSupportApplication extends PhabricatorApplication {
 
+  public function getName() {
+    return pht('Support');
+  }
+
   public function canUninstall() {
     return false;
   }

src/applications/system/application/PhabricatorSystemApplication.php

@@ -2,6 +2,10 @@
 
 final class PhabricatorSystemApplication extends PhabricatorApplication {
 
+  public function getName() {
+    return pht('System');
+  }
+
   public function canUninstall() {
     return false;
   }

src/applications/transactions/application/PhabricatorTransactionsApplication.php

@@ -2,6 +2,10 @@
 
 final class PhabricatorTransactionsApplication extends PhabricatorApplication {
 
+  public function getName() {
+    return pht('Transactions');
+  }
+
   public function isLaunchable() {
     return false;
   }

src/applications/typeahead/application/PhabricatorTypeaheadApplication.php

@@ -2,6 +2,10 @@
 
 final class PhabricatorTypeaheadApplication extends PhabricatorApplication {
 
+  public function getName() {
+    return pht('Typeahead');
+  }
+
   public function getRoutes() {
     return array(
       '/typeahead/' => array(

src/applications/uiexample/application/PhabricatorUIExamplesApplication.php

@@ -10,6 +10,10 @@ final class PhabricatorUIExamplesApplication extends PhabricatorApplication {
     return pht('Developer UI Examples');
   }
 
+  public function getName() {
+    return pht('UIExamples');
+  }
+
   public function getIconName() {
     return 'uiexamples';
   }

src/applications/xhprof/application/PhabricatorXHProfApplication.php

@@ -6,6 +6,10 @@ final class PhabricatorXHProfApplication extends PhabricatorApplication {
     return '/xhprof/';
   }
 
+  public function getName() {
+    return pht('XHProf');
+  }
+
   public function getShortDescription() {
     return pht('PHP Profiling Tool');
   }