Integrate subscriptions with ApplicationTransactions

Summary: Fixes T2214. For objects which support ApplicationTransaction, use ApplicationTransactions to apply subscription action changes. Principally, this makes clicking "Subscribe" / "Unsubscribe" appear correctly in the transaction log.

Test Plan: Clicked "Subscribe" and "Unsubscribe" a on Macros and Mocks.

Reviewers: chad

Reviewed By: chad

CC: aran

Maniphest Tasks: T2214

Differential Revision: https://secure.phabricator.com/D4986

src/__phutil_library_map__.php

@@ -680,6 +680,7 @@ phutil_register_library_map(array(
     'PhabricatorApplicationTransactionController' => 'applications/transactions/controller/PhabricatorApplicationTransactionController.php',
     'PhabricatorApplicationTransactionEditor' => 'applications/transactions/editor/PhabricatorApplicationTransactionEditor.php',
     'PhabricatorApplicationTransactionFeedStory' => 'applications/transactions/feed/PhabricatorApplicationTransactionFeedStory.php',
+    'PhabricatorApplicationTransactionInterface' => 'applications/transactions/interface/PhabricatorApplicationTransactionInterface.php',
     'PhabricatorApplicationTransactionNoEffectException' => 'applications/transactions/exception/PhabricatorApplicationTransactionNoEffectException.php',
     'PhabricatorApplicationTransactionNoEffectResponse' => 'applications/transactions/response/PhabricatorApplicationTransactionNoEffectResponse.php',
     'PhabricatorApplicationTransactionQuery' => 'applications/transactions/query/PhabricatorApplicationTransactionQuery.php',
@@ -2390,6 +2391,7 @@ phutil_register_library_map(array(
     array(
       0 => 'PhabricatorFileDAO',
       1 => 'PhabricatorSubscribableInterface',
+      2 => 'PhabricatorApplicationTransactionInterface',
     ),
     'PhabricatorFileInfoController' => 'PhabricatorFileController',
     'PhabricatorFileLinkListView' => 'AphrontView',

src/applications/macro/storage/PhabricatorFileImageMacro.php

@@ -1,7 +1,9 @@
 <?php
 
 final class PhabricatorFileImageMacro extends PhabricatorFileDAO
-  implements PhabricatorSubscribableInterface {
+  implements
+    PhabricatorSubscribableInterface,
+    PhabricatorApplicationTransactionInterface {
 
   protected $filePHID;
   protected $phid;
@@ -23,5 +25,13 @@ final class PhabricatorFileImageMacro extends PhabricatorFileDAO
     return false;
   }
 
+  public function getApplicationTransactionEditor() {
+    return new PhabricatorMacroEditor();
+  }
+
+  public function getApplicationTransactionObject() {
+    return new PhabricatorMacroTransaction();
+  }
+
 }
 

src/applications/pholio/storage/PholioMock.php

@@ -8,7 +8,8 @@ final class PholioMock extends PholioDAO
     PhabricatorMarkupInterface,
     PhabricatorPolicyInterface,
     PhabricatorSubscribableInterface,
-    PhabricatorTokenReceiverInterface {
+    PhabricatorTokenReceiverInterface,
+    PhabricatorApplicationTransactionInterface {
 
   const MARKUP_FIELD_DESCRIPTION  = 'markup:description';
 
@@ -123,4 +124,17 @@ final class PholioMock extends PholioDAO
     return (bool)$this->getID();
   }
 
+
+/* -(  PhabricatorApplicationTransactionInterface  )------------------------- */
+
+
+  public function getApplicationTransactionEditor() {
+    return new PholioMockEditor();
+  }
+
+  public function getApplicationTransactionObject() {
+    return new PholioTransaction();
+  }
+
+
 }

src/applications/subscriptions/controller/PhabricatorSubscriptionsEditController.php

@@ -58,17 +58,49 @@ final class PhabricatorSubscriptionsEditController
         $handle->getURI());
     }
 
-    $editor = id(new PhabricatorSubscriptionsEditor())
+    if ($object instanceof PhabricatorApplicationTransactionInterface) {
-      ->setActor($user)
+      if ($is_add) {
-      ->setObject($object);
+        $xaction_value = array(
+          '+' => array($user->getPHID()),
+        );
+      } else {
+        $xaction_value = array(
+          '-' => array($user->getPHID()),
+        );
+      }
 
-    if ($is_add) {
+      $xaction = id($object->getApplicationTransactionObject())
-      $editor->subscribeExplicit(array($user->getPHID()), $explicit = true);
+        ->setTransactionType(PhabricatorTransactions::TYPE_SUBSCRIBERS)
+        ->setNewValue($xaction_value);
+
+      $editor = id($object->getApplicationTransactionEditor())
+        ->setActor($user)
+        ->setContinueOnNoEffect(true)
+        ->setContentSource(
+          PhabricatorContentSource::newForSource(
+            PhabricatorContentSource::SOURCE_WEB,
+            array(
+              'ip' => $request->getRemoteAddr(),
+            )));
+
+      $editor->applyTransactions($object, array($xaction));
     } else {
-      $editor->unsubscribe(array($user->getPHID()));
-    }
 
-    $editor->save();
+      // TODO: Eventually, get rid of this once everything implements
+      // PhabriatorApplicationTransactionInterface.
+
+      $editor = id(new PhabricatorSubscriptionsEditor())
+        ->setActor($user)
+        ->setObject($object);
+
+      if ($is_add) {
+        $editor->subscribeExplicit(array($user->getPHID()), $explicit = true);
+      } else {
+        $editor->unsubscribe(array($user->getPHID()));
+      }
+
+      $editor->save();
+    }
 
     // TODO: We should just render the "Unsubscribe" action and swap it out
     // in the document for Ajax requests.

src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php

@@ -170,9 +170,20 @@ abstract class PhabricatorApplicationTransactionEditor
       case PhabricatorTransactions::TYPE_SUBSCRIBERS:
         $subeditor = id(new PhabricatorSubscriptionsEditor())
           ->setObject($object)
-          ->setActor($this->requireActor())
+          ->setActor($this->requireActor());
-          ->subscribeExplicit($xaction->getNewValue())
+
-          ->save();
+        $old_map = array_fuse($xaction->getOldValue());
+        $new_map = array_fuse($xaction->getNewValue());
+
+        $subeditor->unsubscribe(
+          array_keys(
+            array_diff_key($old_map, $new_map)));
+
+        $subeditor->subscribeExplicit(
+          array_keys(
+            array_diff_key($new_map, $old_map)));
+
+        $subeditor->save();
         break;
     }
     return $this->applyCustomExternalTransaction($object, $xaction);

src/applications/transactions/interface/PhabricatorApplicationTransactionInterface.php

@@ -0,0 +1,8 @@
+<?php
+
+interface PhabricatorApplicationTransactionInterface {
+
+  public function getApplicationTransactionEditor();
+  public function getApplicationTransactionObject();
+
+}