revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-27 09:12:41 +01:00
Code Issues Releases Wiki Activity

Make Herald have "exists" and "not exists" options for differential reviewers on commit rules

Browse source 
Summary: Fixes T1485.

Test Plan: made a herald rule for "not exists". committed to master with no diff. audit was triggered

Reviewers: epriestley

Reviewed By: epriestley

CC: Korvin, aran

Maniphest Tasks: T1485

Differential Revision: https://secure.phabricator.com/D6964
This commit is contained in:
Bob Trahan 2013-09-12 16:00:09 -07:00
parent ab2ae9e47f
commit 0ce85df708
1 changed files with 7 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
src/applications/herald/adapter/HeraldCommitAdapter.php
View file

@ -71,6 +71,13 @@ final class HeraldCommitAdapter extends HeraldAdapter {
public function getConditionsForField($field) { public function getConditionsForField($field) {
switch ($field) { switch ($field) {
case self::FIELD_DIFFERENTIAL_REVIEWERS: case self::FIELD_DIFFERENTIAL_REVIEWERS:
return array(
self::CONDITION_EXISTS,
self::CONDITION_NOT_EXISTS,
self::CONDITION_INCLUDE_ALL,
self::CONDITION_INCLUDE_ANY,
self::CONDITION_INCLUDE_NONE,
);
case self::FIELD_DIFFERENTIAL_CCS: case self::FIELD_DIFFERENTIAL_CCS:
return array( return array(
self::CONDITION_INCLUDE_ALL, self::CONDITION_INCLUDE_ALL,