mirror of
https://we.phorge.it/source/phorge.git
synced 2024-11-29 02:02:41 +01:00
Fix PHP 8.1 "strlen(null)" exception which blocks rendering Configuration's Settings page
Summary: `strlen()` was used in Phabricator to check if a generic value is a non-empty string. This behavior is deprecated since PHP 8.1. Phorge adopts `phutil_nonempty_string()` as a replacement. Note: this may highlight other absurd input values that might be worth correcting instead of just ignoring. If phutil_nonempty_string() throws an exception in your instance, report it to Phorge to evaluate and fix that specific corner case. Closes T15324 Test Plan: Applied this change and `/config/settings/` rendered in web browser. Reviewers: O1 Blessed Committers, valerio.bozzolan Reviewed By: O1 Blessed Committers, valerio.bozzolan Subscribers: speck, tobiaswiese, valerio.bozzolan, Matthew, Cigaryno Maniphest Tasks: T15324 Differential Revision: https://we.phorge.it/D25171
This commit is contained in:
parent
1d8483a9bd
commit
0ceb44c38a
1 changed files with 1 additions and 1 deletions
|
@ -7,7 +7,7 @@ final class PhabricatorConfigSettingsListController
|
|||
$viewer = $request->getViewer();
|
||||
|
||||
$filter = $request->getURIData('filter');
|
||||
if (!strlen($filter)) {
|
||||
if (!phutil_nonempty_string($filter)) {
|
||||
$filter = 'settings';
|
||||
}
|
||||
|
||||
|
|
Loading…
Reference in a new issue