From 0d87fef5731f89e1647adffa336e314469b9c88b Mon Sep 17 00:00:00 2001 From: epriestley Date: Tue, 3 Jun 2014 17:08:13 -0700 Subject: [PATCH] Fix an issue where Mercurial pushes would consider only the first and last commits Summary: Fixes T5197. `hg log --rev x --rev y` means "rev x, and also rev y". Use `--rev x:y`, which means "all commits between x and y, inclusive". Test Plan: Pushed 4 commits at once, got 4 commits in push log. Reviewers: btrahan Reviewed By: btrahan Subscribers: epriestley Maniphest Tasks: T5197 Differential Revision: https://secure.phabricator.com/D9309 --- .../diffusion/engine/DiffusionCommitHookEngine.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/applications/diffusion/engine/DiffusionCommitHookEngine.php b/src/applications/diffusion/engine/DiffusionCommitHookEngine.php index 1845f6e2f3..d4f0df94b7 100644 --- a/src/applications/diffusion/engine/DiffusionCommitHookEngine.php +++ b/src/applications/diffusion/engine/DiffusionCommitHookEngine.php @@ -695,8 +695,8 @@ final class DiffusionCommitHookEngine extends Phobject { $futures['old']->updateEnv('HG_PENDING', null); $futures['commits'] = $repository->getLocalCommandFuture( - "log --rev %s --rev tip --template %s", - hgsprintf('%s', $hg_node), + 'log --rev %s --template %s', + hgsprintf('%s:%s', $hg_node, 'tip'), '{node}\1{branches}\2'); // Resolve all of the futures now. We don't need the 'commits' future yet,