Diffusion - fix another commit importing case.

Summary: Fixes T6395. Ref T6350. I guess I missed this code spot in prior testing / I definitely didn't run an empty commit through it. Works now though.

Test Plan: made an empty commit and observed stuck importing status and errors in phd log. applied patch and commit successfully imported with no errors. made another empty commit and it imported as well

Reviewers: epriestley

Reviewed By: epriestley

Subscribers: Korvin, epriestley

Maniphest Tasks: T6350, T6395

Differential Revision: https://secure.phabricator.com/D10746

src/applications/diffusion/data/DiffusionCommitHash.php

@@ -23,4 +23,15 @@ final class DiffusionCommitHash extends Phobject {
     return $this->hashType;
   }
 
+  public static function convertArrayToObjects(array $hashes) {
+    $hash_objects = array();
+    foreach ($hashes as $hash) {
+      $type = $hash[0];
+      $hash = $hash[1];
+      $hash_objects[] = id(new DiffusionCommitHash())
+        ->setHashType($type)
+        ->setHashValue($hash);
+    }
+    return $hash_objects;
+  }
 }

src/applications/diffusion/query/lowlevel/DiffusionLowLevelCommitFieldsQuery.php

@@ -71,6 +71,8 @@ final class DiffusionLowLevelCommitFieldsQuery
         $revision = $this->pickBestRevision($revisions);
         $fields['revisionID'] = $revision->getID();
         $revision_hashes = $revision->getHashes();
+        $revision_hashes = DiffusionCommitHash::convertArrayToObjects(
+          $revision_hashes);
         $revision_hashes = mpull($revision_hashes, 'getHashType');
         // sort the hashes in the order the mighty
         // @{class:ArcanstDifferentialRevisionHash} does; probably unnecessary
@@ -79,7 +81,10 @@ final class DiffusionLowLevelCommitFieldsQuery
           $revision_hashes,
           ArcanistDifferentialRevisionHash::getTypes());
         foreach ($hashes as $hash) {
-          $revision_hash = $revision_hashes[$hash->getHashType()];
+          $revision_hash = idx($revision_hashes, $hash->getHashType());
+          if (!$revision_hash) {
+            continue;
+          }
           if ($revision_hash->getHashValue() == $hash->getHashValue()) {
             $this->setRevisionMatchData(
               'matchHashType',