From 0dfc84e2abef6d14d51de5da63c22a023b8130dd Mon Sep 17 00:00:00 2001 From: Valerio Bozzolan Date: Wed, 19 Jul 2023 21:27:06 +0200 Subject: [PATCH] Ponder Answer Comments: indent textarea as Comments Summary: In a Ponder Answer, when adding a Comment, the textarea indentation was a a little bit unintuitive. After this change, the textarea is aligned as a Comment: | Before | After | |-----------|-----------| | {F286220} | {F286221} | Other changes are welcome but this seems to me a good minimum. I also hope this could help not to confuse the Comment field with the Answer field. Closes T15350 Test Plan: - create a Ponder Question - create an Answer - look at the Comments input field that now should be more nicely indented - the normal Response field is not changed at all - the mobile view is not changed at all - click on "Pin Form On Screen" and it must be as before Reviewers: O1 Blessed Committers, avivey Reviewed By: O1 Blessed Committers, avivey Subscribers: speck, tobiaswiese, Matthew, Cigaryno Maniphest Tasks: T15350 Differential Revision: https://we.phorge.it/D25192 --- resources/celerity/map.php | 4 ++-- webroot/rsrc/css/application/ponder/ponder-view.css | 7 +++++++ 2 files changed, 9 insertions(+), 2 deletions(-) diff --git a/resources/celerity/map.php b/resources/celerity/map.php index 35001dff29..29bc9d9eb8 100644 --- a/resources/celerity/map.php +++ b/resources/celerity/map.php @@ -100,7 +100,7 @@ return array( 'rsrc/css/application/policy/policy-edit.css' => '8794e2ed', 'rsrc/css/application/policy/policy-transaction-detail.css' => 'c02b8384', 'rsrc/css/application/policy/policy.css' => 'ceb56a08', - 'rsrc/css/application/ponder/ponder-view.css' => '05a09d0a', + 'rsrc/css/application/ponder/ponder-view.css' => 'b04bbaff', 'rsrc/css/application/project/project-card-view.css' => 'c1200da7', 'rsrc/css/application/project/project-triggers.css' => 'cd9c8bb9', 'rsrc/css/application/project/project-view.css' => '2f7caa20', @@ -901,7 +901,7 @@ return array( 'policy-css' => 'ceb56a08', 'policy-edit-css' => '8794e2ed', 'policy-transaction-detail-css' => 'c02b8384', - 'ponder-view-css' => '05a09d0a', + 'ponder-view-css' => 'b04bbaff', 'project-card-view-css' => 'c1200da7', 'project-triggers-css' => 'cd9c8bb9', 'project-view-css' => '2f7caa20', diff --git a/webroot/rsrc/css/application/ponder/ponder-view.css b/webroot/rsrc/css/application/ponder/ponder-view.css index 966fb6a1fb..567d7ae99b 100644 --- a/webroot/rsrc/css/application/ponder/ponder-view.css +++ b/webroot/rsrc/css/application/ponder/ponder-view.css @@ -44,10 +44,17 @@ margin-top: 16px; } +/* Indent comments so that are more related to the answer */ .device-desktop .ponder-answer-view .phui-timeline-view { margin-left: 32px; } +/* Indent input box so that it's more related to answer's comments */ +.device-desktop .ponder-answer-view +.phui-comment-form-view:not(.remarkup-assist-pinned) { + margin-left: 94px; +} + .ponder-answer-view .phui-header-subheader { display: inline; margin-left: 12px;