1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-18 21:02:41 +01:00

Fix Column Edit URI, simple dropdown UI

Summary: Fix the URL to editing columns, fix the color of a PHUIX dropdown(simple)

Test Plan: Click on Dropdown, don't feel offended. Edit a Column from various search URLs. Fixes T5341

Reviewers: epriestley

Reviewed By: epriestley

Subscribers: epriestley, Korvin

Maniphest Tasks: T5341

Differential Revision: https://secure.phabricator.com/D9507
This commit is contained in:
Chad Little 2014-06-12 18:15:11 -07:00
parent 933c6317c2
commit 0e1042db85
3 changed files with 9 additions and 9 deletions

View file

@ -7,7 +7,7 @@
return array( return array(
'names' => 'names' =>
array( array(
'core.pkg.css' => 'c76b553b', 'core.pkg.css' => '3a40ccda',
'core.pkg.js' => '8335fe3f', 'core.pkg.js' => '8335fe3f',
'darkconsole.pkg.js' => 'ca8671ce', 'darkconsole.pkg.js' => 'ca8671ce',
'differential.pkg.css' => '4a93db37', 'differential.pkg.css' => '4a93db37',
@ -123,7 +123,7 @@ return array(
'rsrc/css/phui/calendar/phui-calendar-month.css' => 'a92e47d2', 'rsrc/css/phui/calendar/phui-calendar-month.css' => 'a92e47d2',
'rsrc/css/phui/calendar/phui-calendar.css' => '5e1ad989', 'rsrc/css/phui/calendar/phui-calendar.css' => '5e1ad989',
'rsrc/css/phui/phui-box.css' => '7b3a2eed', 'rsrc/css/phui/phui-box.css' => '7b3a2eed',
'rsrc/css/phui/phui-button.css' => '1c771ff8', 'rsrc/css/phui/phui-button.css' => 'c7412aa1',
'rsrc/css/phui/phui-document.css' => 'a5615198', 'rsrc/css/phui/phui-document.css' => 'a5615198',
'rsrc/css/phui/phui-feed-story.css' => 'e2c9bc83', 'rsrc/css/phui/phui-feed-story.css' => 'e2c9bc83',
'rsrc/css/phui/phui-fontkit.css' => 'de84aa4a', 'rsrc/css/phui/phui-fontkit.css' => 'de84aa4a',
@ -747,7 +747,7 @@ return array(
'phrequent-css' => 'ffc185ad', 'phrequent-css' => 'ffc185ad',
'phriction-document-css' => '7d7f0071', 'phriction-document-css' => '7d7f0071',
'phui-box-css' => '7b3a2eed', 'phui-box-css' => '7b3a2eed',
'phui-button-css' => '1c771ff8', 'phui-button-css' => 'c7412aa1',
'phui-calendar-css' => '5e1ad989', 'phui-calendar-css' => '5e1ad989',
'phui-calendar-day-css' => 'de035c8a', 'phui-calendar-day-css' => 'de035c8a',
'phui-calendar-list-css' => 'c1d0ca59', 'phui-calendar-list-css' => 'c1d0ca59',

View file

@ -162,7 +162,7 @@ final class PhabricatorProjectBoardViewController
->setHeader($column->getDisplayName()) ->setHeader($column->getDisplayName())
->setHeaderColor($column->getHeaderColor()); ->setHeaderColor($column->getHeaderColor());
if (!$column->isDefaultColumn()) { if (!$column->isDefaultColumn()) {
$panel->setEditURI('column/'.$column->getID().'/'); $panel->setEditURI($board_uri.'column/'.$column->getID().'/');
} }
$panel->setHeaderAction(id(new PHUIIconView()) $panel->setHeaderAction(id(new PHUIIconView())
->setIconFont('fa-plus') ->setIconFont('fa-plus')
@ -290,11 +290,6 @@ final class PhabricatorProjectBoardViewController
->setHref('#') ->setHref('#')
->addSigil('boards-filter-menu') ->addSigil('boards-filter-menu')
/*
TODO: @chad, this looks really gnarly right now, at least in Safari.
->setDropdown(true)
*/
->setMetadata( ->setMetadata(
array( array(
'items' => hsprintf('%s', $filter_menu), 'items' => hsprintf('%s', $filter_menu),

View file

@ -124,6 +124,11 @@ button.simple:hover {
box-shadow: none; box-shadow: none;
} }
a.button.simple.phuix-dropdown-open {
background-color: #fff;
box-shadow: none;
}
a.button.grey:hover, a.button.grey:hover,
button.grey:hover { button.grey:hover {
text-decoration: none; text-decoration: none;