Make profile menu /edit/ requests explicitly 404

Summary:
See D17160. Previously, the `/edit/` route was never linked, but fataled when accessed. Make it 404 instead.

Also, fix an issue where editing "Application" menu items would fail because they didn't have a viewer.

Test Plan:
  - Hit `/edit/`, got a 404.
  - Edited an "Application" item.
  - Moved, added, deleted, and edited other items.

Reviewers: chad

Reviewed By: chad

Differential Revision: https://secure.phabricator.com/D17165

src/applications/search/engine/PhabricatorProfileMenuEngine.php

@@ -114,6 +114,16 @@ abstract class PhabricatorProfileMenuEngine extends Phobject {
           return new Aphront404Response();
         }
         break;
+      case 'edit':
+        if (!$request->getURIData('id')) {
+          // If we continue along the "edit" pathway without an ID, we hit an
+          // unrelated exception because we can not build a new menu item out
+          // of thin air. For menus, new items are created via the "new"
+          // action. Just catch this case and 404 early since there's currently
+          // no clean way to make EditEngine aware of this.
+          return new Aphront404Response();
+        }
+        break;
     }
 
     $navigation = $this->buildNavigation();

src/applications/search/query/PhabricatorProfileMenuItemConfigurationQuery.php

@@ -80,6 +80,7 @@ final class PhabricatorProfileMenuItemConfigurationQuery
         continue;
       }
       $item_type = clone $item_type;
+      $item_type->setViewer($this->getViewer());
       $item->attachMenuItem($item_type);
     }