From 0e53f91c97016d0278bd503551e83b4ec8475e89 Mon Sep 17 00:00:00 2001
From: Andre Klapper <a9016009@gmx.de>
Date: Wed, 17 Apr 2024 13:07:47 +0200
Subject: [PATCH] Fix PHP 8.1 "strlen(null)" exception for "/bin/herald test"
 without parameter

Summary:
`strlen()` was used in Phabricator to check if a generic value is a non-empty string.
This behavior is deprecated since PHP 8.1. Phorge adopts `phutil_nonempty_string()` as a replacement.

Note: this may highlight other absurd input values that might be worth correcting
instead of just ignoring. If phutil_nonempty_string() throws an exception in your
instance, report it to Phorge to evaluate and fix that specific corner case.

This patch also fixes another similar strlen() occurrence in the same source file.

```
ERROR 8192: strlen(): Passing null to parameter #1 ($string) of type string is deprecated at [/var/www/html/phorge/phorge/src/applications/herald/management/HeraldTestManagementWorkflow.php:33]
```

Test Plan: Run `../phorge/bin/herald test`: Get no `strlen()` error anymore but only expected output `Usage Exception: Specify an object to test rules for with "--object".`

Reviewers: O1 Blessed Committers, valerio.bozzolan

Reviewed By: O1 Blessed Committers, valerio.bozzolan

Subscribers: tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Differential Revision: https://we.phorge.it/D25586
---
 .../herald/management/HeraldTestManagementWorkflow.php        | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/applications/herald/management/HeraldTestManagementWorkflow.php b/src/applications/herald/management/HeraldTestManagementWorkflow.php
index d58e7c4190..f7dd0e3e19 100644
--- a/src/applications/herald/management/HeraldTestManagementWorkflow.php
+++ b/src/applications/herald/management/HeraldTestManagementWorkflow.php
@@ -30,7 +30,7 @@ final class HeraldTestManagementWorkflow
     $viewer = $this->getViewer();
 
     $object_name = $args->getArg('object');
-    if (!strlen($object_name)) {
+    if (!phutil_nonempty_string($object_name)) {
       throw new PhutilArgumentUsageException(
         pht('Specify an object to test rules for with "--object".'));
     }
@@ -69,7 +69,7 @@ final class HeraldTestManagementWorkflow
 
 
     $content_type = $args->getArg('type');
-    if (!strlen($content_type)) {
+    if (!phutil_nonempty_string($content_type)) {
       throw new PhutilArgumentUsageException(
         pht(
           'Specify a content type to run rules for. For this object, valid '.