diff --git a/resources/sql/autopatches/20140224.dxclean.1.datecommitted.sql b/resources/sql/autopatches/20140224.dxclean.1.datecommitted.sql new file mode 100644 index 0000000000..65f2cbe7b6 --- /dev/null +++ b/resources/sql/autopatches/20140224.dxclean.1.datecommitted.sql @@ -0,0 +1,2 @@ +ALTER TABLE {$NAMESPACE}_differential.differential_revision + DROP dateCommitted; diff --git a/src/applications/differential/conduit/ConduitAPI_differential_close_Method.php b/src/applications/differential/conduit/ConduitAPI_differential_close_Method.php index f59aff2767..d5cdb7ebfb 100644 --- a/src/applications/differential/conduit/ConduitAPI_differential_close_Method.php +++ b/src/applications/differential/conduit/ConduitAPI_differential_close_Method.php @@ -60,7 +60,6 @@ final class ConduitAPI_differential_close_Method $editor->save(); $revision->setStatus(ArcanistDifferentialRevisionStatus::CLOSED); - $revision->setDateCommitted(time()); $revision->save(); return; diff --git a/src/applications/differential/editor/DifferentialCommentEditor.php b/src/applications/differential/editor/DifferentialCommentEditor.php index 525ea7259a..1e50c4dcec 100644 --- a/src/applications/differential/editor/DifferentialCommentEditor.php +++ b/src/applications/differential/editor/DifferentialCommentEditor.php @@ -409,10 +409,6 @@ final class DifferentialCommentEditor extends PhabricatorEditor { } } - if (!$revision->getDateCommitted()) { - $revision->setDateCommitted(time()); - } - $revision->setStatus(ArcanistDifferentialRevisionStatus::CLOSED); break; diff --git a/src/applications/differential/editor/DifferentialTransactionEditor.php b/src/applications/differential/editor/DifferentialTransactionEditor.php index 59f83b39c1..c2ee36ae4b 100644 --- a/src/applications/differential/editor/DifferentialTransactionEditor.php +++ b/src/applications/differential/editor/DifferentialTransactionEditor.php @@ -143,11 +143,6 @@ final class DifferentialTransactionEditor // TODO: Update review status? break; case DifferentialAction::ACTION_CLOSE: - if (!$object->getDateCommitted()) { - // TODO: Can we remove this? It is probably no longer used by - // anything anymore. See also T4434. - $object->setDateCommitted(time()); - } $object->setStatus(ArcanistDifferentialRevisionStatus::CLOSED); break; default: diff --git a/src/applications/differential/storage/DifferentialRevision.php b/src/applications/differential/storage/DifferentialRevision.php index 8acd3c3f6f..76379884d6 100644 --- a/src/applications/differential/storage/DifferentialRevision.php +++ b/src/applications/differential/storage/DifferentialRevision.php @@ -20,8 +20,6 @@ final class DifferentialRevision extends DifferentialDAO protected $authorPHID; protected $lastReviewerPHID; - protected $dateCommitted; - protected $lineCount = 0; protected $attached = array(); diff --git a/src/applications/repository/worker/commitmessageparser/PhabricatorRepositoryCommitMessageParserWorker.php b/src/applications/repository/worker/commitmessageparser/PhabricatorRepositoryCommitMessageParserWorker.php index aa1295523d..b9941be50d 100644 --- a/src/applications/repository/worker/commitmessageparser/PhabricatorRepositoryCommitMessageParserWorker.php +++ b/src/applications/repository/worker/commitmessageparser/PhabricatorRepositoryCommitMessageParserWorker.php @@ -117,7 +117,6 @@ abstract class PhabricatorRepositoryCommitMessageParserWorker $diff = $this->attachToRevision($revision, $actor_phid); - $revision->setDateCommitted($commit->getEpoch()); $editor = new DifferentialCommentEditor( $revision, DifferentialAction::ACTION_CLOSE);