Allow EditEngine to build NUX buttons that point at the right place

Summary:
Fixes T11812.

  - Pull the logic for building the "Create Whatever" dropdown out.
  - Use it to generate NUX buttons, too.
  - Use the new logic in Paste and Maniphest.

Test Plan:
  - Viewed Paste NUX, button worked.
  - Viewed Maniphest NUX with multiple create forms, button worked.

Reviewers: chad, avivey

Reviewed By: avivey

Subscribers: avivey

Maniphest Tasks: T11812

Differential Revision: https://secure.phabricator.com/D16797

src/applications/maniphest/query/ManiphestTaskSearchEngine.php

@@ -405,11 +405,11 @@ final class ManiphestTaskSearchEngine
   }
 
   protected function getNewUserBody() {
-    $create_button = id(new PHUIButtonView())
+    $viewer = $this->requireViewer();
-      ->setTag('a')
+
-      ->setText(pht('Create a Task'))
+    $create_button = id(new ManiphestEditEngine())
-      ->setHref('/maniphest/task/edit/')
+      ->setViewer($viewer)
-      ->setColor(PHUIButtonView::GREEN);
+      ->newNUXBUtton(pht('Create a Task'));
 
     $icon = $this->getApplication()->getIcon();
     $app_name =  $this->getApplication()->getName();

src/applications/paste/query/PhabricatorPasteSearchEngine.php

@@ -204,11 +204,11 @@ final class PhabricatorPasteSearchEngine
   }
 
   protected function getNewUserBody() {
-    $create_button = id(new PHUIButtonView())
+    $viewer = $this->requireViewer();
-      ->setTag('a')
+
-      ->setText(pht('Create a Paste'))
+    $create_button = id(new PhabricatorPasteEditEngine())
-      ->setHref('/paste/create/')
+      ->setViewer($viewer)
-      ->setColor(PHUIButtonView::GREEN);
+      ->newNUXButton(pht('Create a Paste'));
 
     $icon = $this->getApplication()->getIcon();
     $app_name =  $this->getApplication()->getName();

src/applications/transactions/editengine/PhabricatorEditEngine.php

@@ -1352,11 +1352,80 @@ abstract class PhabricatorEditEngine
   }
 
 
+  public function newNUXButton($text) {
+    $specs = $this->newCreateActionSpecifications(array());
+    $head = head($specs);
+
+    return id(new PHUIButtonView())
+      ->setTag('a')
+      ->setText($text)
+      ->setHref($head['uri'])
+      ->setDisabled($head['disabled'])
+      ->setWorkflow($head['workflow'])
+      ->setColor(PHUIButtonView::GREEN);
+  }
+
+
   final public function addActionToCrumbs(
     PHUICrumbsView $crumbs,
     array $parameters = array()) {
     $viewer = $this->getViewer();
 
+    $specs = $this->newCreateActionSpecifications($parameters);
+
+    $head = head($specs);
+    $menu_uri = $head['uri'];
+
+    $dropdown = null;
+    if (count($specs) > 1) {
+      $menu_icon = 'fa-caret-square-o-down';
+      $menu_name = $this->getObjectCreateShortText();
+      $workflow = false;
+      $disabled = false;
+
+      $dropdown = id(new PhabricatorActionListView())
+        ->setUser($viewer);
+
+      foreach ($specs as $spec) {
+        $dropdown->addAction(
+          id(new PhabricatorActionView())
+            ->setName($spec['name'])
+            ->setIcon($spec['icon'])
+            ->setHref($spec['uri']))
+            ->setDisabled($head['disabled'])
+            ->setWorkflow($head['workflow']);
+      }
+
+    } else {
+      $menu_icon = $head['icon'];
+      $menu_name = $head['name'];
+
+      $workflow = $head['workflow'];
+      $disabled = $head['disabled'];
+    }
+
+    $action = id(new PHUIListItemView())
+      ->setName($menu_name)
+      ->setHref($menu_uri)
+      ->setIcon($menu_icon)
+      ->setWorkflow($workflow)
+      ->setDisabled($disabled);
+
+    if ($dropdown) {
+      $action->setDropdownMenu($dropdown);
+    }
+
+    $crumbs->addAction($action);
+  }
+
+
+  /**
+   * Build a raw description of available "Create New Object" UI options so
+   * other methods can build menus or buttons.
+   */
+  private function newCreateActionSpecifications(array $parameters) {
+    $viewer = $this->getViewer();
+
     $can_create = $this->hasCreateCapability();
     if ($can_create) {
       $configs = $this->loadUsableConfigurationsForCreate();
@@ -1364,12 +1433,11 @@ abstract class PhabricatorEditEngine
       $configs = array();
     }
 
-    $dropdown = null;
     $disabled = false;
     $workflow = false;
 
     $menu_icon = 'fa-plus-square';
-
+    $specs = array();
     if (!$configs) {
       if ($viewer->isLoggedIn()) {
         $disabled = true;
@@ -1385,22 +1453,15 @@ abstract class PhabricatorEditEngine
       } else {
         $create_uri = $this->getEditURI(null, 'nocreate/');
       }
+
+      $specs[] = array(
+        'name' => $this->getObjectCreateShortText(),
+        'uri' => $create_uri,
+        'icon' => $menu_icon,
+        'disabled' => $disabled,
+        'workflow' => $workflow,
+      );
     } else {
-      $config = head($configs);
-      $form_key = $config->getIdentifier();
-      $create_uri = $this->getEditURI(null, "form/{$form_key}/");
-
-      if ($parameters) {
-        $create_uri = (string)id(new PhutilURI($create_uri))
-          ->setQueryParams($parameters);
-      }
-
-      if (count($configs) > 1) {
-        $menu_icon = 'fa-caret-square-o-down';
-
-        $dropdown = id(new PhabricatorActionListView())
-          ->setUser($viewer);
-
       foreach ($configs as $config) {
         $form_key = $config->getIdentifier();
         $config_uri = $this->getEditURI(null, "form/{$form_key}/");
@@ -1410,29 +1471,17 @@ abstract class PhabricatorEditEngine
             ->setQueryParams($parameters);
         }
 
-          $item_icon = 'fa-plus';
+        $specs[] = array(
-
+          'name' => $config->getDisplayName(),
-          $dropdown->addAction(
+          'uri' => $config_uri,
-            id(new PhabricatorActionView())
+          'icon' => 'fa-plus',
-              ->setName($config->getDisplayName())
+          'disabled' => false,
-              ->setIcon($item_icon)
+          'workflow' => false,
-              ->setHref($config_uri));
+        );
-        }
       }
     }
 
-    $action = id(new PHUIListItemView())
+    return $specs;
-      ->setName($this->getObjectCreateShortText())
-      ->setHref($create_uri)
-      ->setIcon($menu_icon)
-      ->setWorkflow($workflow)
-      ->setDisabled($disabled);
-
-    if ($dropdown) {
-      $action->setDropdownMenu($dropdown);
-    }
-
-    $crumbs->addAction($action);
   }
 
   final public function buildEditEngineCommentView($object) {