Policy Header rollout

Summary: Adds policy headers to more (all?) places currently in use.

Test Plan: test each page changed.

Reviewers: epriestley

Reviewed By: epriestley

CC: Korvin, aran

Differential Revision: https://secure.phabricator.com/D7032

src/applications/diviner/controller/DivinerBookController.php

@@ -32,7 +32,16 @@ final class DivinerBookController extends DivinerController {
         ->setName($book->getShortTitle())
         ->setHref('/book/'.$book->getName().'/'));
 
-    $header = id(new PHUIHeaderView())->setHeader($book->getTitle());
+    $policies = PhabricatorPolicyQuery::renderPolicyDescriptions(
+      $viewer,
+      $book,
+      true);
+
+    $header = id(new PHUIHeaderView())
+      ->setHeader($book->getTitle())
+      ->addProperty(PHUIHeaderView::PROPERTY_POLICY,
+        $policies[PhabricatorPolicyCapability::CAN_VIEW]);
+
     $document = new PHUIDocumentView();
     $document->setHeader($header);
 
@@ -88,10 +97,6 @@ final class DivinerBookController extends DivinerController {
       $user,
       $book);
 
-    $view->addProperty(
-      pht('Visible To'),
-      $policies[PhabricatorPolicyCapability::CAN_VIEW]);
-
     $view->addProperty(
       pht('Updated'),
       phabricator_datetime($book->getDateModified(), $user));

src/applications/phame/controller/blog/PhameBlogViewController.php

@@ -33,8 +33,15 @@ final class PhameBlogViewController extends PhameController {
 
     $nav = $this->renderSideNavFilterView(null);
 
+    $descriptions = PhabricatorPolicyQuery::renderPolicyDescriptions(
+      $user,
+      $blog,
+      true);
+
     $header = id(new PHUIHeaderView())
-      ->setHeader($blog->getName());
+      ->setHeader($blog->getName())
+      ->addProperty(PHUIHeaderView::PROPERTY_POLICY,
+        $descriptions[PhabricatorPolicyCapability::CAN_VIEW]);
 
     $handle_phids = array_merge(
       mpull($posts, 'getBloggerPHID'),
@@ -111,10 +118,6 @@ final class PhameBlogViewController extends PhameController {
       $user,
       $blog);
 
-    $properties->addProperty(
-      pht('Visible To'),
-      $descriptions[PhabricatorPolicyCapability::CAN_VIEW]);
-
     $properties->addProperty(
       pht('Editable By'),
       $descriptions[PhabricatorPolicyCapability::CAN_EDIT]);

src/applications/phame/controller/post/PhamePostViewController.php

@@ -34,6 +34,11 @@ final class PhamePostViewController extends PhameController {
     $actions = $this->renderActions($post, $user);
     $properties = $this->renderProperties($post, $user);
 
+    $descriptions = PhabricatorPolicyQuery::renderPolicyDescriptions(
+      $user,
+      $post,
+      true);
+
     $crumbs = $this->buildApplicationCrumbs();
     $crumbs->setActionList($actions);
     $crumbs->addCrumb(
@@ -44,7 +49,9 @@ final class PhamePostViewController extends PhameController {
     $nav->appendChild($crumbs);
     $nav->appendChild(
       id(new PHUIHeaderView())
-        ->setHeader($post->getTitle()));
+        ->setHeader($post->getTitle())
+        ->addProperty(PHUIHeaderView::PROPERTY_POLICY,
+          $descriptions[PhabricatorPolicyCapability::CAN_VIEW]));
 
     if ($post->isDraft()) {
       $nav->appendChild(
@@ -167,10 +174,6 @@ final class PhamePostViewController extends PhameController {
       ->setUser($user)
       ->setObject($post);
 
-    $descriptions = PhabricatorPolicyQuery::renderPolicyDescriptions(
-      $user,
-      $post);
-
     $properties->addProperty(
       pht('Blog'),
       $post->getBlogPHID()
@@ -181,10 +184,6 @@ final class PhamePostViewController extends PhameController {
       pht('Blogger'),
       $this->getHandle($post->getBloggerPHID())->renderLink());
 
-    $properties->addProperty(
-      pht('Visible To'),
-      $descriptions[PhabricatorPolicyCapability::CAN_VIEW]);
-
     $properties->addProperty(
       pht('Published'),
       $post->isDraft()

src/applications/phlux/controller/PhluxViewController.php

@@ -30,8 +30,15 @@ final class PhluxViewController extends PhluxController {
         ->setName($title)
         ->setHref($request->getRequestURI()));
 
+    $descriptions = PhabricatorPolicyQuery::renderPolicyDescriptions(
+      $user,
+      $var,
+      true);
+
     $header = id(new PHUIHeaderView())
-      ->setHeader($title);
+      ->setHeader($title)
+      ->addProperty(PHUIHeaderView::PROPERTY_POLICY,
+        $descriptions[PhabricatorPolicyCapability::CAN_VIEW]);
 
     $actions = id(new PhabricatorActionListView())
       ->setUser($user)
@@ -53,17 +60,10 @@ final class PhluxViewController extends PhluxController {
 
     $display_value = json_encode($var->getVariableValue());
 
-    $descriptions = PhabricatorPolicyQuery::renderPolicyDescriptions(
-      $user,
-      $var);
-
     $properties = id(new PhabricatorPropertyListView())
       ->setUser($user)
       ->setObject($var)
       ->addProperty(pht('Value'), $display_value)
-      ->addProperty(
-        pht('Visible To'),
-        $descriptions[PhabricatorPolicyCapability::CAN_VIEW])
       ->addProperty(
         pht('Editable By'),
         $descriptions[PhabricatorPolicyCapability::CAN_EDIT]);

src/applications/slowvote/controller/PhabricatorSlowvotePollController.php

@@ -41,8 +41,15 @@ final class PhabricatorSlowvotePollController
           ));
     }
 
+    $descriptions = PhabricatorPolicyQuery::renderPolicyDescriptions(
+      $user,
+      $poll,
+      true);
+
     $header = id(new PHUIHeaderView())
-      ->setHeader($poll->getQuestion());
+      ->setHeader($poll->getQuestion())
+      ->addProperty(PHUIHeaderView::PROPERTY_POLICY,
+        $descriptions[PhabricatorPolicyCapability::CAN_VIEW]);
 
     $xaction_header = id(new PHUIHeaderView())
       ->setHeader(pht('Ongoing Deliberations'));
@@ -111,14 +118,6 @@ final class PhabricatorSlowvotePollController
       ->setUser($viewer)
       ->setObject($poll);
 
-    $descriptions = PhabricatorPolicyQuery::renderPolicyDescriptions(
-      $viewer,
-      $poll);
-
-    $view->addProperty(
-      pht('Visible To'),
-      $descriptions[PhabricatorPolicyCapability::CAN_VIEW]);
-
     $view->invokeWillRenderEvent();
 
     if (strlen($poll->getDescription())) {