From 104eefaa10d9f34e09aae71e135c1d5bd982e5c5 Mon Sep 17 00:00:00 2001 From: epriestley Date: Fri, 3 May 2019 07:58:26 -0700 Subject: [PATCH] Hide the "added a commit/revision" stories from feed and mail Summary: Ref T13276. Previously, these edges were added directly with an `EdgeEditor`, so they did not generate transaction stories. Now, they're added properly, but they aren't terribly useful in feed/mail. Hide them in those contexts, like we already do with other types of similar edges. Test Plan: Will verify behavior on `secure`. Reviewers: amckinley Reviewed By: amckinley Maniphest Tasks: T13276 Differential Revision: https://secure.phabricator.com/D20491 --- .../storage/PhabricatorApplicationTransaction.php | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/applications/transactions/storage/PhabricatorApplicationTransaction.php b/src/applications/transactions/storage/PhabricatorApplicationTransaction.php index 4b65c1b815..a55d5ce73e 100644 --- a/src/applications/transactions/storage/PhabricatorApplicationTransaction.php +++ b/src/applications/transactions/storage/PhabricatorApplicationTransaction.php @@ -703,6 +703,8 @@ abstract class PhabricatorApplicationTransaction case DifferentialRevisionDependedOnByRevisionEdgeType::EDGECONST: case ManiphestTaskHasCommitEdgeType::EDGECONST: case DiffusionCommitHasTaskEdgeType::EDGECONST: + case DiffusionCommitHasRevisionEdgeType::EDGECONST: + case DifferentialRevisionHasCommitEdgeType::EDGECONST: return true; case PhabricatorProjectObjectHasProjectEdgeType::EDGECONST: // When an object is first created, we hide any corresponding @@ -762,6 +764,8 @@ abstract class PhabricatorApplicationTransaction case DifferentialRevisionDependedOnByRevisionEdgeType::EDGECONST: case ManiphestTaskHasCommitEdgeType::EDGECONST: case DiffusionCommitHasTaskEdgeType::EDGECONST: + case DiffusionCommitHasRevisionEdgeType::EDGECONST: + case DifferentialRevisionHasCommitEdgeType::EDGECONST: return true; default: break;