From 107d6db1e8f638f40e3f7489a380480f1c9869ef Mon Sep 17 00:00:00 2001
From: epriestley <git@epriestley.com>
Date: Mon, 18 May 2015 12:18:10 -0700
Subject: [PATCH] Don't put a spacer line on the bottom of previews

Summary: Fixes T8182. See screenshot in that task. We currently render a line to nowhere at the bottom of these previews. Instead, only render a line at the top.

Test Plan:
{F409078}

Also looked at a couple other applications that use this and they looked correct.

Reviewers: btrahan, lpriestley, chad

Reviewed By: chad

Subscribers: epriestley

Maniphest Tasks: T8182

Differential Revision: https://secure.phabricator.com/D12905
---
 resources/celerity/map.php                     | 18 +++++++++---------
 .../behavior-transaction-comment-form.js       |  3 +--
 2 files changed, 10 insertions(+), 11 deletions(-)

diff --git a/resources/celerity/map.php b/resources/celerity/map.php
index 5b985f4de7..10b67a500e 100644
--- a/resources/celerity/map.php
+++ b/resources/celerity/map.php
@@ -401,7 +401,7 @@ return array(
     'rsrc/js/application/search/behavior-reorder-queries.js' => 'e9581f08',
     'rsrc/js/application/slowvote/behavior-slowvote-embed.js' => '887ad43f',
     'rsrc/js/application/transactions/behavior-show-older-transactions.js' => 'dbbf48b6',
-    'rsrc/js/application/transactions/behavior-transaction-comment-form.js' => '9f7309fb',
+    'rsrc/js/application/transactions/behavior-transaction-comment-form.js' => 'b23b49e6',
     'rsrc/js/application/transactions/behavior-transaction-list.js' => '13c739ea',
     'rsrc/js/application/typeahead/behavior-typeahead-browse.js' => '635de1ec',
     'rsrc/js/application/typeahead/behavior-typeahead-search.js' => '93d0c9e3',
@@ -610,7 +610,7 @@ return array(
     'javelin-behavior-phabricator-search-typeahead' => '048330fa',
     'javelin-behavior-phabricator-show-older-transactions' => 'dbbf48b6',
     'javelin-behavior-phabricator-tooltips' => '3ee3408b',
-    'javelin-behavior-phabricator-transaction-comment-form' => '9f7309fb',
+    'javelin-behavior-phabricator-transaction-comment-form' => 'b23b49e6',
     'javelin-behavior-phabricator-transaction-list' => '13c739ea',
     'javelin-behavior-phabricator-watch-anchor' => '9f36c42d',
     'javelin-behavior-phame-post-preview' => 'be807912',
@@ -1581,13 +1581,6 @@ return array(
       'javelin-dom',
       'javelin-vector',
     ),
-    '9f7309fb' => array(
-      'javelin-behavior',
-      'javelin-dom',
-      'javelin-util',
-      'javelin-request',
-      'phabricator-shaped-request',
-    ),
     'a0b57eb8' => array(
       'javelin-behavior',
       'javelin-dom',
@@ -1677,6 +1670,13 @@ return array(
       'javelin-dom',
       'javelin-reactor-dom',
     ),
+    'b23b49e6' => array(
+      'javelin-behavior',
+      'javelin-dom',
+      'javelin-util',
+      'javelin-request',
+      'phabricator-shaped-request',
+    ),
     'b2b4fbaf' => array(
       'javelin-behavior',
       'javelin-dom',
diff --git a/webroot/rsrc/js/application/transactions/behavior-transaction-comment-form.js b/webroot/rsrc/js/application/transactions/behavior-transaction-comment-form.js
index 119ec02d21..935116c3b3 100644
--- a/webroot/rsrc/js/application/transactions/behavior-transaction-comment-form.js
+++ b/webroot/rsrc/js/application/transactions/behavior-transaction-comment-form.js
@@ -26,8 +26,7 @@ JX.behavior('phabricator-transaction-comment-form', function(config) {
         JX.$(config.timelineID),
         [
           JX.$H(response.spacer),
-          JX.$H(response.xactions.join(response.spacer)),
-          JX.$H(response.spacer)
+          JX.$H(response.xactions.join(response.spacer))
         ]);
       JX.DOM.show(panel);
     }