From 108ffb9e0aa7bc4997e8cd96537f9ff2a50df286 Mon Sep 17 00:00:00 2001
From: Bob Trahan <bob.trahan@gmail.com>
Date: Thu, 19 Jul 2012 09:44:23 -0700
Subject: [PATCH] Fix small bugs regarding Maniphest Task <=> Differential
 Revision attachments

Summary:
introduced in D3006, D3007. we need a list of phids for revision and now that its attachments its always two way.

without this patch revisions don't show up on maniphest and attaching from either mani or diffu only has the attachment show up where you did it. (since two_way = false)

Test Plan: attached revisions and tasks to one another and verified things were showing up where they should

Reviewers: epriestley

Reviewed By: epriestley

CC: aran, Korvin

Differential Revision: https://secure.phabricator.com/D3011
---
 .../maniphest/controller/ManiphestTaskDetailController.php      | 2 +-
 .../search/controller/PhabricatorSearchAttachController.php     | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/applications/maniphest/controller/ManiphestTaskDetailController.php b/src/applications/maniphest/controller/ManiphestTaskDetailController.php
index ec0e10003d..f2e8199141 100644
--- a/src/applications/maniphest/controller/ManiphestTaskDetailController.php
+++ b/src/applications/maniphest/controller/ManiphestTaskDetailController.php
@@ -180,7 +180,7 @@ final class ManiphestTaskDetailController extends ManiphestController {
     $revs = idx($attached, PhabricatorPHIDConstants::PHID_TYPE_DREV);
     if ($revs) {
       $dict['Revisions'] = $this->renderHandleList(
-        array_select_keys($handles, $revs));
+        array_select_keys($handles, array_keys($revs)));
     }
 
     if ($commit_phids) {
diff --git a/src/applications/search/controller/PhabricatorSearchAttachController.php b/src/applications/search/controller/PhabricatorSearchAttachController.php
index 5da51c0334..4c04ff5f04 100644
--- a/src/applications/search/controller/PhabricatorSearchAttachController.php
+++ b/src/applications/search/controller/PhabricatorSearchAttachController.php
@@ -104,7 +104,7 @@ final class PhabricatorSearchAttachController
             $editor->attachObjects(
               $attach_type,
               $phids,
-              $two_way = false);
+              $two_way = true);
 
             return id(new AphrontReloadResponse())->setURI($handle->getURI());
           default: