From 112acf11cf518b2716da6b7792b598fbfc4e8274 Mon Sep 17 00:00:00 2001
From: Jason Ge <jungejason@fb.com>
Date: Mon, 18 Jun 2012 11:09:25 -0700
Subject: [PATCH] Enable 'jumping to toc' on diffusion commit page

Summary:
Diffusion page is sharing the keyboard shortcuts code with
Differential page. But since the toc (Changes) panel doesn't have id
'differential-review-toc', the 'jumping to toc' doesn't work. The fix is
to add the ID. I don't like adding 'Differential' to the Diffusion page.
Later we should refactor the code to extract the shared components out of Differential.

Test Plan:
verified that 't' worked on the diffusion commit page.

Reviewers: epriestley, nh

Reviewed By: epriestley

CC: hwang, aran, Korvin

Differential Revision: https://secure.phabricator.com/D2500
---
 .../diffusion/controller/DiffusionCommitController.php           | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/applications/diffusion/controller/DiffusionCommitController.php b/src/applications/diffusion/controller/DiffusionCommitController.php
index c043b7f698..874397a539 100644
--- a/src/applications/diffusion/controller/DiffusionCommitController.php
+++ b/src/applications/diffusion/controller/DiffusionCommitController.php
@@ -162,6 +162,7 @@ final class DiffusionCommitController extends DiffusionController {
     } else {
       $change_panel = new AphrontPanelView();
       $change_panel->setHeader("Changes (".number_format($count).")");
+      $change_panel->setID('differential-review-toc');
 
       if ($count !== $original_changes_count) {
         $show_all_button = phutil_render_tag(