revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-23 22:10:55 +01:00
Code Issues Releases Wiki Activity

Rename "commitType" to "symbolicType"

Browse source 
Summary:
Ref T2683. The old name was a bit confusing because it meant "the type of the thing the symbol represents": a "commit type" should logically always be "commit".

(Currently, this is only used to detect when we're looking at a tag.)

Test Plan: Looked at a tag. Looked at some other non-tag things. Browsed around, `grep`.

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: epriestley

Maniphest Tasks: T2683

Differential Revision: https://secure.phabricator.com/D9092
This commit is contained in:
epriestley 2014-05-13 13:52:03 -07:00
parent 9a2c68fd88
commit 112c9e6b5e
2 changed files with 7 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/applications/diffusion/controller/DiffusionBrowseController.php
View file

@ -157,7 +157,7 @@ abstract class DiffusionBrowseController extends DiffusionController {
), ),
$drequest->getRepository()->formatCommitName($stable_commit))); $drequest->getRepository()->formatCommitName($stable_commit)));
if ($drequest->getCommitType() == 'tag') { if ($drequest->getSymbolicType() == 'tag') {
$symbolic = $drequest->getSymbolicCommit(); $symbolic = $drequest->getSymbolicCommit();
$view->addProperty(pht('Tag'), $symbolic); $view->addProperty(pht('Tag'), $symbolic);

12
src/applications/diffusion/request/DiffusionRequest.php
View file

@ -16,11 +16,11 @@ abstract class DiffusionRequest {
protected $path; protected $path;
protected $line; protected $line;
protected $commit; protected $commit;
protected $commitType = 'commit';
protected $branch; protected $branch;
protected $lint; protected $lint;
protected $symbolicCommit; protected $symbolicCommit;
protected $symbolicType;
protected $stableCommit; protected $stableCommit;
protected $repository; protected $repository;
@ -244,6 +244,10 @@ abstract class DiffusionRequest {
return $this->symbolicCommit; return $this->symbolicCommit;
} }
public function getSymbolicType() {
return $this->symbolicType;
}
public function getBranch() { public function getBranch() {
return $this->branch; return $this->branch;
} }
@ -630,11 +634,7 @@ abstract class DiffusionRequest {
$match = head($matches); $match = head($matches);
$this->commit = $match['identifier']; $this->commit = $match['identifier'];
$this->commitType = $match['type']; $this->symbolicType = $match['type'];
}
public function getCommitType() {
return $this->commitType;
} }
private function queryStableCommit() { private function queryStableCommit() {