Fix application name toolip hover

Summary: Ref T12174. We were always setting a name via builtins so the tooltip was always set. Fix the calls here.

Test Plan: Add "Badges", see tooltip, give "Badges" a name of "Badges", don't see tooltip.

Reviewers: epriestley

Reviewed By: epriestley

Subscribers: Korvin

Maniphest Tasks: T12174

Differential Revision: https://secure.phabricator.com/D17284

src/applications/home/engine/PhabricatorHomeProfileMenuEngine.php

@@ -39,7 +39,7 @@ final class PhabricatorHomeProfileMenuEngine
       }
 
       $properties = array(
-        'name' => $application->getName(),
+        'name' => '',
         'application' => $application->getPHID(),
       );
 

src/applications/search/menuitem/PhabricatorApplicationProfileMenuItem.php

@@ -89,7 +89,8 @@ final class PhabricatorApplicationProfileMenuItem
       ->setIcon($app->getIcon());
 
     // Don't show tooltip if they've set a custom name
-    if (strlen(($config->getMenuItemProperty('name')))) {
+    $name = $config->getMenuItemProperty('name');
+    if (!strlen($name)) {
       $item->setTooltip($app->getShortDescription());
     }